Split the settings database data into a new file and added a more detailed settings export file name, using the tab title. #145
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OB Description
Please include a summary of the change and which issue is fixed. Please provide enough information so that others can review your pull request. Explain the details for making this change. What existing problem does the pull request solve?
Demonstrate the code is solid. Include the exact commands you ran and their CLI output, screenshots or videos. List any dependencies that are required for this change.
The first commit was in response to this assigned issue: #95
The settings.txt file will be saved with the dashboard title added to the beginning of the file before export.
The rest of the commits are for making the password suffixes code more explicit and the most recent one has the most changes compared to the other ones.
The most recent commit was created in response to this assigned issue: #111
An important note is that I wasn't able to encrypt the sensitive data as requested as this would prevent obplayer from restarting on it's own and it would need a password protected private key file to be somewhat secure
The approach I took to solving this issue was recommend by BrookeGagnon and changes the way sensitive data is stored on the filesystem with more resurrective file permissions to maintain current functionally without inducing new bugs. Now the data is split and migrated from the database into the safer
.openbroadcaster/.secrets.jsonlocation.Please review this careful to make sure I didn't miss any bugs or other issues.
**IMPORTANT: Search previous suggestions before making a new one, as yours may be a duplicate. Do not create a Pull Request without creating an issue first.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Testing Environments
OpenBroadcaster Component and Version
Browser Version?
OS Version?
Checklist:
Thanks for contributing!