Skip to content

Conversation

@TroyWarez
Copy link
Contributor

@TroyWarez TroyWarez commented Nov 20, 2025

OB Description

Please include a summary of the change and which issue is fixed. Please provide enough information so that others can review your pull request. Explain the details for making this change. What existing problem does the pull request solve?
Demonstrate the code is solid. Include the exact commands you ran and their CLI output, screenshots or videos. List any dependencies that are required for this change.

The first commit was in response to this assigned issue: #95
The settings.txt file will be saved with the dashboard title added to the beginning of the file before export.

The rest of the commits are for making the password suffixes code more explicit and the most recent one has the most changes compared to the other ones.

The most recent commit was created in response to this assigned issue: #111

An important note is that I wasn't able to encrypt the sensitive data as requested as this would prevent obplayer from restarting on it's own and it would need a password protected private key file to be somewhat secure

The approach I took to solving this issue was recommend by BrookeGagnon and changes the way sensitive data is stored on the filesystem with more resurrective file permissions to maintain current functionally without inducing new bugs. Now the data is split and migrated from the database into the safer .openbroadcaster/.secrets.json location.

Please review this careful to make sure I didn't miss any bugs or other issues.

**IMPORTANT: Search previous suggestions before making a new one, as yours may be a duplicate. Do not create a Pull Request without creating an issue first.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Testing Environments

OpenBroadcaster Component and Version

  • OBServer
  • OBPlayer 5.3-develop
  • Module
  • Other

Browser Version?

  • Chrome
  • Edge\IE: 142.0.0.0
  • Firefox
  • Safari
  • Other

OS Version?

  • BSD
  • Debian
  • Raspberry OS
  • Ubuntu (Flavour) 24.04
  • Other

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code and corrected any misspellings
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant