Add generic task config and activity#200
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
GianlucaFicarelli
force-pushed
the
add_generic_tasks
branch
from
f9a7c10 to
7dd8148
Compare
GianlucaFicarelli
force-pushed
the
add_generic_tasks
branch
from
7dd8148 to
a4c0cdf
Compare
eleftherioszisis
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes for openbraininstitute/entitycore#542
Besides adding TaskActivity and TaskConfig, this PR adds the context to the serialization functions, allowing to specify a different serialization depending on
context.when: create, update, read.This would allow to keep a single model, that can be serialized differently.
In many cases, entitycore would ignore additional attributes passed in the create or update requests, but they can now be filtered out in this way.
In this PR, this is applied to
TaskConfig.inputsonly, but it could be applied in other cases (including activities, to serializeusedandgenerated)EDIT: changed in the commit ff94fc5, now the serialization is done directly in serdes.py