Skip to content

Add derivation from em_dense_reconstruction_dataset to cell_morphology#617

Merged
GianlucaFicarelli merged 1 commit into
mainfrom
new_derivation_dataset
May 26, 2026
Merged

Add derivation from em_dense_reconstruction_dataset to cell_morphology#617
GianlucaFicarelli merged 1 commit into
mainfrom
new_derivation_dataset

Conversation

@GianlucaFicarelli
Copy link
Copy Markdown
Collaborator

@GianlucaFicarelli GianlucaFicarelli commented May 26, 2026

About naming:
em_dense_reconstruction_dataset_cell_morphology is just the concatenation of the used and generated entity types as for emodel_circuit.
Alternatives:

  • use a name that describes the purpose of the derivation as em_skeletonization
  • use unspecified as it is used for electrical_cell_recording to emodel, but it would be harder to filter by type

For reference, the existing derivation types are:

  • circuit_customization (circuit to circuit)
  • circuit_extraction (circuit to circuit)
  • circuit_rewiring (circuit to circuit)
  • emodel_circuit (emodel to circuit)
  • unspecified (electrical_cell_recording to emodel)

Fix #604
cc @MWolfR

@GianlucaFicarelli GianlucaFicarelli self-assigned this May 26, 2026
@GianlucaFicarelli GianlucaFicarelli changed the title Add em_dense_reconstruction_dataset_cell_morphology derivation Add derivation from em_dense_reconstruction_dataset to cell_morphology May 26, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
pytest 97.45% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app/db/types.py 99.50% <100.00%> (+<0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GianlucaFicarelli GianlucaFicarelli merged commit 7cde872 into main May 26, 2026
2 checks passed
@GianlucaFicarelli GianlucaFicarelli deleted the new_derivation_dataset branch May 26, 2026 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add derivation_type em_skeletonization to Derivation

3 participants