Skip to content

initial v1.4 version, with MULTIPLE_SPINES#26

Draft
mgeplf wants to merge 2 commits into
masterfrom
spines
Draft

initial v1.4 version, with MULTIPLE_SPINES#26
mgeplf wants to merge 2 commits into
masterfrom
spines

Conversation

@mgeplf
Copy link
Copy Markdown
Collaborator

@mgeplf mgeplf commented Nov 27, 2025

No description provided.

@coveralls
Copy link
Copy Markdown

coveralls commented Nov 27, 2025

Pull Request Test Coverage Report for Build 19740564934

Details

  • 15 of 17 (88.24%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 77.159%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/readers/morphologyHDF5.cpp 14 16 87.5%
Totals Coverage Status
Change from base Build 19738136656: 0.008%
Covered Lines: 2216
Relevant Lines: 2872

💛 - Coveralls

Copy link
Copy Markdown
Contributor

@jplanasc jplanasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested with a small morphology with spines.

@jplanasc
Copy link
Copy Markdown
Contributor

@mgeplf : The only thing to me is that I can't seem to get spine neck/head as NeuriteType, I'm not sure if this was expected.

After discussing with @MWolfR , it would be nice to have (for the future).

Thanks!

@mgeplf
Copy link
Copy Markdown
Collaborator Author

mgeplf commented Jan 12, 2026

The only thing to me is that I can't seem to get spine neck/head as NeuriteType, I'm not sure if this was expected.

Sure.

We probably need to add the documentation for that in the section: https://github.com/openbraininstitute/morphology-documentation/pull/1/changes#r2682605628

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants