Skip to content

Fix case-sensitive morphology path handling on Linux#85

Merged
ilkilic merged 4 commits into
mainfrom
fix-morph-path-linux
May 4, 2026
Merged

Fix case-sensitive morphology path handling on Linux#85
ilkilic merged 4 commits into
mainfrom
fix-morph-path-linux

Conversation

@ilkilic
Copy link
Copy Markdown
Collaborator

@ilkilic ilkilic commented May 1, 2026

Follow-up to case-insensitive morphology path support (#83).

The previous change handled path resolution in MorphIOWrapper but morphology paths can fail earlier during NeuronTemplate validation. This PR resolves plain morphology file paths before validation as well. It also stops normalizing morphology extensions to lowercase so the extension case from the resolved filesystem path is preserved. H5 container paths remain excluded from filesystem path resolution to avoid treating HDF5 keys as directory components.

@ilkilic ilkilic self-assigned this May 1, 2026
@ilkilic ilkilic requested a review from pgetta May 1, 2026 13:12
@codecov
Copy link
Copy Markdown

codecov Bot commented May 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
bluecellulab/cell/core.py 78.92% <100.00%> (ø)
bluecellulab/cell/morphio_wrapper.py 97.89% <ø> (-0.02%) ⬇️
bluecellulab/cell/template.py 97.34% <100.00%> (+0.04%) ⬆️
tests/test_cell/test_morphology_wrapper.py 96.95% <100.00%> (+0.02%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ilkilic ilkilic merged commit c5e1ac7 into main May 4, 2026
9 checks passed
@ilkilic ilkilic deleted the fix-morph-path-linux branch May 4, 2026 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants