Conversation
01a92eb to
ac6770b
Compare
3f9a1e0 to
bf5def3
Compare
bf5def3 to
81020c3
Compare
## Summary
Adds Codex UI metadata to every skill and refactors the build tooling so
each skill directory is self-contained (assets copied in)
### Main changes
**Codex marketplace metadata** (`skills/*/agents/openai.yaml`):
Each skill now ships an `agents/openai.yaml` with `interface` fields
(`display_name`, `short_description`, `icon_small`/`icon_large`,
`brand_color`, `default_prompt`). These are installed as files by the
CLI and consumed by Codex for marketplace display.
**Self-contained skill directories with asset sync**
(`scripts/skills.py`):
Renamed `scripts/generate_manifest.py` to `scripts/skills.py` and
expanded it into a three-mode tool: `sync` copies shared assets
(`assets/databricks.{svg,png}`) from repo root into each skill's
`assets/` dir (idempotent, preserves mtime via `copy2`); `generate` runs
sync then writes `manifest.json` with plain relative paths (no `@root:`
prefix); `validate` checks both asset sync state and manifest freshness,
printing a fix command on failure.
**Skill rename: `databricks` to `databricks-core`** (`manifest.json`):
The old `databricks` skill entry (which mapped to `skills/databricks/`)
is replaced by `databricks-core` (mapping to `skills/databricks-core/`).
The orphan `skills/databricks/` directory is removed.
### Supporting infrastructure
- **`assets/databricks.svg`** — Shared Databricks vector logo (source of
truth for all skills).
- **`assets/databricks.png`** — Shared Databricks raster logo.
- **`skills/*/assets/databricks.{svg,png}`** — Per-skill copies
generated by `scripts/skills.py sync`.
### Other changes
- `.github/workflows/validate-manifest.yml` updated to reference
`scripts/skills.py validate` and trigger on `assets/**` changes.
- `CLAUDE.md` and `README.md` updated to document the new
`scripts/skills.py` commands (`sync`, `generate`, `validate`).
## Preview
**Skills installer**
<img width="462" height="142" alt="image"
src="https://github.com/user-attachments/assets/58254c75-f8bd-4494-8df4-cc996e93e776"
/>
**In chat**
<img width="394" height="113" alt="image"
src="https://github.com/user-attachments/assets/0248e2bb-2391-492f-baef-e881c2821731"
/>
**All skills installed**
<img width="1016" height="338" alt="image"
src="https://github.com/user-attachments/assets/3c8757c8-2269-4db5-9120-d01df561d088"
/>
Codex UI will have this skill openai/skills#307
that uses the CLI to install the rest
## Documentation safety checklist
- [ ] Examples use least-privilege permissions (no unnecessary `ALL
PRIVILEGES`, admin tokens, or broad scopes)
- [ ] Elevated permissions are explicitly called out where required
- [ ] Sensitive values are obfuscated (placeholder workspace IDs, URLs,
no real tokens)
- [ ] No insecure patterns introduced (e.g. disabled TLS verification,
hardcoded credentials)
---------
Co-authored-by: MarioCadenas <MarioCadenas@users.noreply.github.com>
|
hey @dkundel-openai , could I get a review please? thank you! |
| databricks experimental aitools install --global --agents codex | ||
| ``` | ||
|
|
||
| Install one skill with: | ||
|
|
||
| ```bash | ||
| databricks experimental aitools install --global --agents codex --skills databricks-apps |
There was a problem hiding this comment.
[P1] Align installer command with current Databricks docs
The skill’s primary workflow tells Codex to run databricks experimental aitools install --global --agents codex, and the single-skill example repeats that Databricks CLI path. Current Databricks agent-skill documentation instead points users to the Skills CLI (npx skills add databricks/databricks-agent-skills ...) and uses repeated --skill flags for specific skills. Unless this Databricks CLI path is intentionally newer/private, this should be changed to the documented command or backed by an upstream source plus validation, because the current curated skill may fail at its main job.
| @@ -0,0 +1,30 @@ | |||
| --- | |||
There was a problem hiding this comment.
[P2] Add the per-skill license file
This new curated skill directory only adds SKILL.md, agents/openai.yaml, and assets, but no LICENSE.txt. The repo README says each individual skill’s license should live inside the skill directory as LICENSE.txt; that is especially important here because the PR also adds Databricks logo assets whose license/trademark attribution needs to be clear before distribution.
| databricks experimental aitools install --global --agents codex --skills databricks-apps | ||
| ``` | ||
|
|
||
| After installation, open the installed Databricks skill under `${CODEX_HOME:-~/.codex}/skills` and follow its upstream `SKILL.md`. |
There was a problem hiding this comment.
[P2] Tell users to restart Codex after installing
The last instruction says to open the installed skill and follow its SKILL.md, but the repo’s existing installer flow tells users to restart Codex after installing a skill so discovery picks it up. Add that post-install step here, and clarify whether the current session may only manually inspect the installed files until restart.
vb-openai
left a comment
There was a problem hiding this comment.
thanks a lot for the PR @MarioCadenas - (Codex) left some comments, it'd be great if we can iterate on this once!
Summary
Add a new curated skill that installs Databricks agent skills via the Databricks CLI.
Main changes
Databricks Skill Installer (
skills/.curated/databricks-skill-installer/SKILL.md):A new skill that wraps
databricks experimental aitools install --globalto bootstrap or refresh Databricks skills for Codex. It checks for CLI availability first, links to the upstream install guide if missing, and supports both full and single-skill installation.