chore(internal): simplify handling of deployment models #556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openai-java-core/src/main/kotlin/com/openai/core/PrepareRequest.kt
Outdated
Show resolved
Hide resolved
TomerAberbach
changed the title
| else -> it.toString() | ||
| } | ||
| } | ||
| } catch (_: Exception) { |
There was a problem hiding this comment.
Can we put this only around the reflection parts? We only want to catch reflection exceptions (not other errors which may indicate more real issues)
TomerAberbach
approved these changes
Jul 24, 2025
Merged
TomerAberbach
pushed a commit
that referenced
this pull request
Jul 24, 2025
* fix(client): accidental mutability of some classes * chore(internal): remove unnecessary `[...]` in `@see` * docs: more code comments * chore(internal): simplify handling of deployment models (#556) * deployment-models: simplified code handling of deployment models * deployment-models: shorter test function names. * deployment-models: return null if reflection fails. * deployment-models: handle reflection errors more specifically. * release: 2.19.1 --------- Co-authored-by: stainless-app[bot] <142633134+stainless-app[bot]@users.noreply.github.com> Co-authored-by: D Gardner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.