-
Notifications
You must be signed in to change notification settings - Fork 144
feat(client): support new unified Azure URL scheme #554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # openai-java-core/src/main/kotlin/com/openai/azure/HttpRequestBuilderExtensions.kt # openai-java-core/src/main/kotlin/com/openai/core/ClientOptions.kt
openai-java-example/src/main/java/com/openai/example/AzureKeyCredentialExample.java
Outdated
Show resolved
Hide resolved
openai-java-core/src/main/kotlin/com/openai/core/ClientOptions.kt
Outdated
Show resolved
Hide resolved
openai-java-core/src/main/kotlin/com/openai/core/ClientOptions.kt
Outdated
Show resolved
Hide resolved
openai-java-core/src/main/kotlin/com/openai/azure/AzureUrlCategory.kt
Outdated
Show resolved
Hide resolved
openai-java-core/src/main/kotlin/com/openai/azure/HttpRequestBuilderExtensions.kt
Outdated
Show resolved
Hide resolved
…gory.kt Co-authored-by: Tomer Aberbach <[email protected]>
Updated the |
TomerAberbach
approved these changes
Aug 6, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
/openai/v1
Azure endpoints (referred to as "unified", as in "unified with the OpenAI schema", meaning that the model/deployment is not a path parameter of the request URL andapi-version
is optional).api-version
query parameter with the value ofpreview
, but in the future the omission of this query parameter will result in the service defaulting tov1
meaning "latest".azureUrlPathMode
enum as a manual switch between the old behaviour of adding deployment name to the URL and the OpenAI unified URL schema. (Added as an enum to future proof)Azure URL handling changes
api-version
is optional)api-version
is required)For a more detailed discussion on the spec please refer to this message in the original PR thread.
cc: @srnagar and @trrwilson