Log upstream inline image limit rejections

[fjord-oai]

Summary

Add observability for upstream inline image limit rejections.

This change detects Responses API bad requests that look like inline image byte-limit or image-count-limit failures, logs them with structured fields, and records a Statsig-backed counter so we can monitor how often this is happening before the graceful local handling lands.

Changes

• Added inline_image_request_limit_bad_request_observation(...) in core/src/api_bridge.rs to recognize upstream bad-request copy for:
  • inline image byte limit
  • image count limit
• Added structured warning logs in map_api_error(...) for those upstream rejections, including:
  • bytes_exceeded
  • images_exceeded
  • response_status
  • response_body
• Added client-side metric emission in core/src/client.rs when an upstream request is rejected for an inline image limit:
  • metric: codex.responses.inline_image_limit
  • outcome: upstream_rejected
  • tags: bytes_exceeded, images_exceeded
• Covered both the parser and metric emission with focused tests in:
  • core/src/api_bridge_tests.rs
  • core/src/client_tests.rs

git stack

• 👉 1 Log upstream inline image limit rejections #15888
• ⏳ 2 Handle inline image request caps gracefully #15569
• ⏳ 3 Add inline image limit observability #15887

[fjord-oai]

@codex review

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 50877ee692

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[fjord-oai]

@codex review

[chatgpt-codex-connector]

💡 Codex Review

codex/codex-rs/core/src/client.rs

Lines 402 to 405 in e5d5aa8

	client
	.compact_input(&payload, extra_headers)
	.await
	.map_err(map_api_error)

Emit inline-image limit metric for compact requests

compact_conversation_history sends prompt.get_formatted_input() (which can contain inline images) to /responses/compact, but errors are only map_api_error-mapped and returned. Unlike streaming paths, this method never calls record_upstream_inline_image_request_limit_observation, so upstream byte/count-limit rejections are not counted in codex.responses.inline_image_limit.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[fjord-oai]

@codex review

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f9d681d7c3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[fjord-oai]

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Keep it up!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".