Skip to content

fix: add directory guard in formatUntrackedFile to prevent EISDIR crash #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stoneHee99 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: add directory guard in formatUntrackedFile to prevent EISDIR crash #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
407b3ab
fix: skip directories in formatUntrackedFile to prevent EISDIR crash …
stoneHee99 Mar 31, 2026
62c12ce
fix: export formatUntrackedFile and add direct unit test for director…
stoneHee99 Mar 31, 2026
0804ec7
Merge branch 'main' into fix/eisdir-untracked-directories
stoneHee99 Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion plugins/codex/scripts/lib/git.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,9 +133,12 @@ function formatSection(title, body) {
return [`## ${title}`, "", body.trim() ? body.trim() : "(none)", ""].join("\n");
}

function formatUntrackedFile(cwd, relativePath) {
export function formatUntrackedFile(cwd, relativePath) {
const absolutePath = path.join(cwd, relativePath);
const stat = fs.statSync(absolutePath);
if (stat.isDirectory()) {
return `### ${relativePath}\n(skipped: directory)`;
}
if (stat.size > MAX_UNTRACKED_BYTES) {
return `### ${relativePath}\n(skipped: ${stat.size} bytes exceeds ${MAX_UNTRACKED_BYTES} byte limit)`;
}
Expand Down
12 changes: 11 additions & 1 deletion tests/git.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import path from "node:path";
import test from "node:test";
import assert from "node:assert/strict";

import { collectReviewContext, resolveReviewTarget } from "../plugins/codex/scripts/lib/git.mjs";
import { collectReviewContext, formatUntrackedFile, resolveReviewTarget } from "../plugins/codex/scripts/lib/git.mjs";
import { initGitRepo, makeTempDir, run } from "./helpers.mjs";

test("resolveReviewTarget prefers working tree when repo is dirty", () => {
Expand Down Expand Up @@ -68,3 +68,13 @@ test("resolveReviewTarget requires an explicit base when no default branch can b
/Unable to detect the repository default branch\. Pass --base <ref> or use --scope working-tree\./
);
});

test("formatUntrackedFile skips directories instead of throwing EISDIR", () => {
const cwd = makeTempDir();
fs.mkdirSync(path.join(cwd, "some-dir"));

const result = formatUntrackedFile(cwd, "some-dir");

assert.match(result, /skipped: directory/);
assert.match(result, /some-dir/);
});