weak-modules2: don't remove symlinks in the rpm --reinstall case#126
Open
weak-modules2: don't remove symlinks in the rpm --reinstall case#126
Conversation
If a KMP is reinstalled with "rpm -i --reinstall", weak-updates symlinks will be missing because %postun is called after %post. It will think that this KMP is being removed, and delete symlinks pointing to modules from the KMP in question. To avoid that, check in %postun if the number of remaining packages is 1. This can be the update or reinstall case. To distinguish the two, check if another KMP with the same name, but different version/release is installed. If yes, it's an update; otherwise, it makes sense to assume that it's a reinstall and that we shouldn't delete the symlinks. Signed-off-by: Martin Wilck <mwilck@suse.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a KMP is reinstalled with "rpm -i --reinstall", weak-updates symlinks will be missing because %postun is called after %post. It will think that this KMP is being removed, and delete symlinks pointing to modules from the KMP in question.
To avoid that, check in %postun if the number of remaining packages is 1. This can be the update or reinstall case. To distinguish the two, check if another KMP with the same name, but different version/release is installed. If yes, it's an update; otherwise, it makes sense to assume that it's a reinstall and that we shouldn't delete the symlinks.