-
Notifications
You must be signed in to change notification settings - Fork 508
MW-213 Discover and implement kotlin docs and generate documentation #1861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rohitlokhande47
wants to merge
8
commits into
openMF:development
Choose a base branch
from
rohitlokhande47:MW-213-discover-and-implement-kotlin-docs-and-generate-documentation
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
114ae9b
feat: Add documentation comments for AccountViewModel and related cla…
rohitlokhande47 27518ad
feat: Add FeatureLibraryPlugin and update build configuration
rohitlokhande47 d23b76b
feat: Integrate Dokka for documentation generation and update navigat…
rohitlokhande47 7b524a7
feat: Integrate Dokka for documentation generation and update navigat…
rohitlokhande47 93415f6
feat: Refactor navigation popUpTo references to use findStartDestinat…
rohitlokhande47 3607573
feat: Refactor navigation popUpTo references to use findStartDestinat…
rohitlokhande47 7c8fdad
feat: Update build configuration by removing unused dependencies and …
rohitlokhande47 abd4782
Merge branch 'development' into MW-213-discover-and-implement-kotlin-…
niyajali File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 26 additions & 0 deletions
26
build-logic/convention/src/main/kotlin/org/mifospay/Dokka.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| package org.mifospay | ||
|
|
||
| import org.gradle.api.Project | ||
| import org.gradle.kotlin.dsl.withType | ||
|
|
||
| /** | ||
| * Configures Dokka documentation settings for a feature module. | ||
| * This extension function replaces the FeatureLibraryPlugin class by directly | ||
| * applying the same configuration to the target Project. | ||
| */ | ||
| // Add this in a shared convention plugin or utilities script | ||
| fun Project.configureFeatureDocumentation() { | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can remove these configs since we've already defined similar ones in the root build.gradle.kts, which apply project-wide. These should work as expected. Please let us know if you think these serve a different purpose. |
||
| plugins.withId("org.jetbrains.dokka") { | ||
| tasks.withType<org.jetbrains.dokka.gradle.DokkaTask>().configureEach { | ||
| outputDirectory.set(layout.buildDirectory.dir("dokka")) | ||
| moduleName.set(project.name) | ||
|
|
||
| // Add KMP-specific configuration only for multiplatform modules | ||
| if (pluginManager.hasPlugin("org.jetbrains.kotlin.multiplatform")) { | ||
| dokkaSourceSets.configureEach { | ||
| // includes.from("README.md") // Include KMP-specific docs | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -27,4 +27,4 @@ kotlin { | |
| implementation(libs.kotlinx.serialization.json) | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -45,4 +45,5 @@ kotlin { | |
| implementation(libs.play.services.auth) | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is sufficient for docs generation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok I will look into it