feat(core-ui): implement cross-platform file and text sharing #2974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a robust, cross-platform `ShareUtils` implementation for handling text and file sharing across Android, iOS, Desktop (JVM), JS, and WASM.
Key changes include:
- **Common `ShareUtils` expect/actual structure:**
- Defines `shareText(text: String)` and `shareFile(file: ShareFileModel)` in the common module.
- Implements these functions for each target platform.
- **`ShareFileModel` and `MimeType`:**
- Introduces `ShareFileModel` to encapsulate file details (name, bytes, MIME type).
- Adds `MimeType` enum (PDF, TEXT, IMAGE) for better type safety.
- **Platform-specific implementations:**
- **Android:** Uses `Intent.ACTION_SEND` with `FileProvider` for sharing files. Includes image compression via `FileKit`. `setActivityProvider` is required for context.
- **iOS:** Leverages `UIActivityViewController` for native sharing. Handles file saving to cache and uses `FileKit` for image compression.
- **Desktop (JVM):** Uses `FileKit.openFileSaver` to prompt the user to save the file locally, as direct sharing is not typical.
- **JS/WASM:** Uses `FileKit.download` to trigger a browser download for files and text content.
- **Dependency updates:**
- Replaces `libs.filekit.compose` with `libs.filekit.dialog.compose` in `core/ui/build.gradle.kts` for better dialog handling.
- **Helper functions:**
- Android: `saveFile`, `MimeType.toAndroidMimeType`, `compressImage`.
- iOS: `saveFile`, `compressImage`.
This unified approach simplifies sharing logic across the application and leverages platform-specific capabilities where available.
- Excluded `core-base/designsystem/**` from Detekt analysis. - Removed unnecessary `printStackTrace()` calls in `ShareUtils.android.kt` and `ShareUtils.native.kt`. - Applied `modifier` parameter to `MifosAccountApplyDashboard`. - Removed redundant `it ->` in `BottomSheetContent.kt`.
core/ui/src/androidMain/kotlin/org/mifos/mobile/core/ui/utils/ShareUtils.android.kt
Show resolved
Hide resolved
Contributor
Author
|
I just copy pasted the logic from mifos pay. @HekmatullahAmin If you think it can be mergeable. please go ahead and merge it |
HekmatullahAmin
approved these changes
Sep 24, 2025
Member
|
@Nagarjuna0033 i can't merge it ask Mr Rajan to merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a robust, cross-platform
ShareUtilsimplementation for handling text and file sharing across Android, iOS, Desktop (JVM), JS, and WASM.Key changes include:
ShareUtilsexpect/actual structure:shareText(text: String)andshareFile(file: ShareFileModel)in the common module.ShareFileModelandMimeType:ShareFileModelto encapsulate file details (name, bytes, MIME type).MimeTypeenum (PDF, TEXT, IMAGE) for better type safety.Intent.ACTION_SENDwithFileProviderfor sharing files. Includes image compression viaFileKit.setActivityProvideris required for context.UIActivityViewControllerfor native sharing. Handles file saving to cache and usesFileKitfor image compression.FileKit.openFileSaverto prompt the user to save the file locally, as direct sharing is not typical.FileKit.downloadto trigger a browser download for files and text content.libs.filekit.composewithlibs.filekit.dialog.composeincore/ui/build.gradle.ktsfor better dialog handling.saveFile,MimeType.toAndroidMimeType,compressImage.saveFile,compressImage.This unified approach simplifies sharing logic across the application and leverages platform-specific capabilities where available.
Fixes - Jira-#426