Skip to content

chore(build-logic): add missing dependencies to version catalog and complete build logic setup #2967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 7, 2025
Merged

chore(build-logic): add missing dependencies to version catalog and complete build logic setup #2967

merged 3 commits into from
Sep 7, 2025

Conversation

@Nagarjuna0033
Copy link
Contributor

@Nagarjuna0033 Nagarjuna0033 commented Sep 6, 2025

Fixes - Jira-#386

@Nagarjuna0033 Nagarjuna0033 changed the title chore(build-logic): add missing dependencies to version catalog and c… chore(build-logic): add missing dependencies to version catalog and complete build logic setup Sep 6, 2025
@HekmatullahAmin
Copy link
Member

HekmatullahAmin commented Sep 6, 2025

@Nagarjuna0033 as I mentioned in slack channel could u please also update ther version in version.xml according to our template or mifos pay like Kotlin version, ksp, ktorifit and etc....

@Nagarjuna0033
Copy link
Contributor Author

Nagarjuna0033 commented Sep 6, 2025

@Nagarjuna0033 as I mentioned in slack channel could u please also update ther version in version.xml according to our template or mifos pay like Kotlin version, ksp, ktorifit and etc....

version.xml or libs.versions.toml?

@HekmatullahAmin
Copy link
Member

HekmatullahAmin commented Sep 6, 2025

@Nagarjuna0033 as I mentioned in slack channel could u please also update ther version in version.xml according to our template or mifos pay like Kotlin version, ksp, ktorifit and etc....

version.xml or libs.versions.toml?

yeah .toml

@HekmatullahAmin
Copy link
Member

HekmatullahAmin commented Sep 6, 2025

@Nagarjuna0033 fix the errors so we proceed with merge

@Nagarjuna0033
Copy link
Contributor Author

Nagarjuna0033 commented Sep 7, 2025

@Nagarjuna0033 fix the errors so we proceed with merge

@HekmatullahAmin Those are detekt errors in core-base module. We will fix it later

@therajanmaurya therajanmaurya merged commit f47b961 into openMF:development Sep 7, 2025
4 of 5 checks passed
Samriddhi743 pushed a commit to Samriddhi743/mifos-mobile that referenced this pull request Oct 3, 2025
@Nagarjuna0033
chore(build-logic): add missing dependencies to version catalog and c…
5d6c442 
…omplete build logic setup (openMF#2967)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Nagarjuna0033 @HekmatullahAmin @therajanmaurya