Feat: [:core:ui] - Migrated to KMP #2749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@niyajali can you please review it once and tell me whether i am in the right track or not. and what are the changes i have to do? |
niyajali
requested changes
Jan 22, 2025
core/ui/src/commonMain/kotlin/org/mifos/mobile/core/ui/utils/ImageUtil.kt
Outdated
Show resolved
Hide resolved
core/ui/src/commonMain/kotlin/org/mifos/mobile/core/ui/component/UserProfileTopBar.kt
Outdated
Show resolved
Hide resolved
core/ui/src/commonMain/kotlin/org/mifos/mobile/core/ui/component/UserProfileTopBar.kt
Outdated
Show resolved
Hide resolved
core/ui/src/commonMain/kotlin/org/mifos/mobile/core/ui/component/MifosMobileIcon.kt
Outdated
Show resolved
Hide resolved
core/ui/src/commonMain/kotlin/org/mifos/mobile/core/ui/component/MifosMobileIcon.kt
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@niyajali done the changes |
niyajali
requested changes
Jan 23, 2025
core/ui/src/desktopMain/kotlin/org/mifos/mobile/core/ui/utils/ImageUtil.desktop.kt
Outdated
Show resolved
Hide resolved
niyajali
requested changes
Jan 26, 2025
Collaborator
niyajali
left a comment
niyajali
left a comment
There was a problem hiding this comment.
And please don't resolve my conversation, I've to see what I told you and what you done, just comment out done or something below the conversation
core/ui/src/jsMain/kotlin/org/mifos/mobile/core/ui/utils/ImageUtil.js.kt
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@niyajali done all the change . please review it once |
niyajali
approved these changes
Jan 26, 2025
Collaborator
|
@revanthkumarJ fix spotless |
Nagarjuna0033
pushed a commit
to Nagarjuna0033/mifos-mobile
that referenced
this pull request
May 12, 2025
therajanmaurya
pushed a commit
that referenced
this pull request
May 13, 2025
Samriddhi743
pushed a commit
to Samriddhi743/mifos-mobile
that referenced
this pull request
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - Jira-MM-113
Didn't create a Jira ticket, click here to create new.
Please Add Screenshots If there are any UI changes.
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the static analysis check
./gradlew checkorci-prepush.shto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.