-
Notifications
You must be signed in to change notification settings - Fork 771
Feat: [:core:data] - Migrated to KMP #2747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: [:core:data] - Migrated to KMP #2747
Conversation
|
@niyajali brother I have migrated the data module to KMP. This module depends on the database module for charge and notification dao. Once the database module is successfully migrated, I will pull those changes and integrate them. Meanwhile, let me know if there are any changes that need to be made to these files. |
...datastore/src/commonMain/kotlin/org/mifos/mobile/core/datastore/UserPreferencesDataSource.kt
Outdated
Show resolved
Hide resolved
.../data/src/commonMain/kotlin/org/mifos/mobile/core/data/repositoryImpl/ClientRepositoryImp.kt
Outdated
Show resolved
Hide resolved
|
@Nagarjuna0033 We can't wait for the database module to merge because that gonna take time since Room isn't fully supported KMP, we've use SQLDelight so for now, provide an empty or default value into those specific RepositoryImpl functions, later on we'll provide actual implementation. |
28d0652 to
2b17f80
Compare
Suggested changes have been resolved. Could you please review it once? |
niyajali
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, Looks good to me, could be merged
Fixes - Jira-#115
Didn't create a Jira ticket, click here to create new.
Please Add Screenshots If there are any UI changes.
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the static analysis check
./gradlew checkorci-prepush.shto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.