Immediately close a WebSocket connection to a runner #2605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous code mostly worked but there could be cases where stopping was delayed. This is especially problematic with the reservation of runners, since they could still be reserved (internally) without a visual indicator for the learners. The change in the SubmissionsController is optional, since a browser should also close the connection once `close_client_connection` is executed. However, this change might stop the runner earlier, which is especially useful in case of infinite loops.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2605 +/- ##
==========================================
- Coverage 69.56% 69.53% -0.03%
==========================================
Files 202 202
Lines 6370 6372 +2
==========================================
Hits 4431 4431
- Misses 1939 1941 +2 ☔ View full report in Codecov by Sentry. |
Dome-GER
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code mostly worked but there could be cases where stopping was delayed. This is especially problematic with the reservation of runners, since they could still be reserved (internally) without a visual indicator for the learners.
The change in the SubmissionsController is optional, since a browser should also close the connection once
close_client_connectionis executed. However, this change might stop the runner earlier, which is especially useful in case of infinite loops.