fix: export Resource attributes for metrics and traces - #63
Open
bachgarash wants to merge 1 commit into
Open
Conversation
The SDK parsed OTEL_SERVICE_NAME and OTEL_RESOURCE_ATTRIBUTES and built a resource on both TracerProvider and MeterProvider, but neither the trace nor the metrics OTLP exporter attached it to the exported payload. Spans and metrics reached the collector with no resource, so backends could not identify the emitting service: traces appears in Jaeger under missing-service-name and target_info could not be produced for metrics. Carry the provider's resource on the exported data the way logs already do. Also, extract resourceToProtobuf in the metrics exporter so the conversion can be tested without performing an HTTP export, matching the existing separation between spansToOTLPRequest and exportSpans on the trace side. Fixes open-telemetry#62
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SDK parsed OTEL_SERVICE_NAME and OTEL_RESOURCE_ATTRIBUTES and built a resource on both TracerProvider and MeterProvider, but neither the trace nor the metrics OTLP exporter attached it to the exported payload. Spans and metrics reached the collector with no resource, so backends could not identify the emitting service, traces appears in Jaeger under missing-service-name.
Carry the provider's resource on the exported data the way logs already do.
Also, extract resourceToProtobuf in the metrics exporter so the conversion can be tested without performing an HTTP export, matching the existing separation between spansToOTLPRequest and exportSpans on the trace side.
Fixes #62
after the fix