opentelemetry-instrumentation-pymongo: fix invalid mongodb collection attribute type #3942
+54
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where the Mongodb collection name attribute is occasionally incorrectly set to a non-string value for commands that do not operate on collections. The fix implemented is not able to perfectly identifying commands that operate on collections, but compared to the alternative of directly enumerating all collection-based commands, this fix should be adequate for the time being.
Fixes #3940
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
A unit test with several scenarios has been added to validate that only valid collection names are used for the collection name attribute.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.