refactor(opentelemetry-util-http): stop using deprecated SpanAttributes #3592
+29
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the OpenTelemetry utility for HTTP instrumentation by transitioning from the deprecated
SpanAttributes
to the new_incubating.attributes
module for attribute definitions. The changes ensure compatibility with the latest OpenTelemetry conventions and improve maintainability by using the updated attribute module.Transition to
_incubating.attributes
module:util/opentelemetry-util-http/src/opentelemetry/util/http/__init__.py
: Replaced imports ofSpanAttributes
with imports from_incubating.attributes.http_attributes
and_incubating.attributes.net_attributes
. Updated_duration_attrs
and_active_requests_count_attrs
to use the new attributes. [1] [2]util/opentelemetry-util-http/src/opentelemetry/util/http/httplib.py
: ReplacedSpanAttributes.NET_PEER_IP
withNET_PEER_IP
from_incubating.attributes.net_attributes
. Updated thetrysetip
function to use the new attribute. [1] [2]Refs #3475
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.