fix(accounting): align protobuf file paths with make target #2390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f target The accounting service protobuf configuration was inconsistent with the gen_proto_dotnet function used by the make generate-protobuf target. Changes: - Update Accounting.csproj to reference protobuf files at src/protos/demo.proto instead of proto/demo.proto to match gen_proto_dotnet output location - Update Dockerfile to copy protobuf file to Accounting/src/protos/demo.proto to align with project file expectations - Update README.md local build instructions to use make generate-protobuf instead of manual file copying commands
julianocosta89
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The accounting service protobuf configuration was inconsistent with the
gen_proto_dotnetfunction used by themake generate-protobuftarget used for local development.Changes
Please provide a brief description of the changes here.
Merge Requirements
For new features contributions, please make sure you have completed the following
essential items:
CHANGELOG.mdupdated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.