Skip to content

Conversation

tomatopunk
Copy link

Description

Fixes OTLP exporter config validation for Unix socket endpoints. Splits validation for host/port and Unix socket, keeping backward compatibility.

Link to tracking issue

Fixes #13642

Testing

• Added tests for DNS, HTTP, HTTPS, Unix socket, and other schemes.
• Updated sanitize endpoint test; behavior unchanged.
• Unix socket test covered.

Documentation

@tomatopunk tomatopunk requested a review from a team as a code owner August 19, 2025 08:22
@evan-bradley
Copy link
Contributor

@tomatopunk Thanks for the thorough PR. I think we should see if we can solve this in configgrpc, ideally using the grpc-go library. Do you think if we remove the failing validation from the OTLP exporter, we could instead validate the connection URI using an underlying library like in #13630?

@tomatopunk
Copy link
Author

@tomatopunk Thanks for the thorough PR. I think we should see if we can solve this in configgrpc, ideally using the grpc-go library. Do you think if we remove the failing validation from the OTLP exporter, we could instead validate the connection URI using an underlying library like in #13630?

I agree. I have removed the original validation code and now use configgrpc.Valid() for validation. Additionally, I deleted some of the previous test cases, since we can rely on configgrpc to guarantee their correctness.

@tomatopunk
Copy link
Author

Hey @evan-bradley,
Just checking in — is there anything blocking this PR right now?

Do I need to make any more changes, or are we just waiting on #13630 to be merged before it can go through?

It doesn’t bring any breaking changes — it only removes the host port valid for the endpoint. Just trying to get any info on what might be holding it up :)

Copy link

codecov bot commented Aug 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.58%. Comparing base (ed2d996) to head (2d810e3).
⚠️ Report is 72 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13671      +/-   ##
==========================================
+ Coverage   87.63%   91.58%   +3.94%     
==========================================
  Files         632      633       +1     
  Lines       39697    39478     -219     
==========================================
+ Hits        34790    36154    +1364     
+ Misses       3660     2564    -1096     
+ Partials     1247      760     -487     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

github-actions bot commented Sep 6, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added Stale and removed Stale labels Sep 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support unix socket for otlp export
2 participants