-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[exporter/otlp] Fix unix socket blocked with valid #13671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[exporter/otlp] Fix unix socket blocked with valid #13671
Conversation
@tomatopunk Thanks for the thorough PR. I think we should see if we can solve this in configgrpc, ideally using the grpc-go library. Do you think if we remove the failing validation from the OTLP exporter, we could instead validate the connection URI using an underlying library like in #13630? |
I agree. I have removed the original validation code and now use configgrpc.Valid() for validation. Additionally, I deleted some of the previous test cases, since we can rely on configgrpc to guarantee their correctness. |
Hey @evan-bradley, Do I need to make any more changes, or are we just waiting on #13630 to be merged before it can go through? It doesn’t bring any breaking changes — it only removes the host port valid for the endpoint. Just trying to get any info on what might be holding it up :) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13671 +/- ##
==========================================
+ Coverage 87.63% 91.58% +3.94%
==========================================
Files 632 633 +1
Lines 39697 39478 -219
==========================================
+ Hits 34790 36154 +1364
+ Misses 3660 2564 -1096
+ Partials 1247 760 -487 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Description
Fixes OTLP exporter config validation for Unix socket endpoints. Splits validation for host/port and Unix socket, keeping backward compatibility.
Link to tracking issue
Fixes #13642
Testing
• Added tests for DNS, HTTP, HTTPS, Unix socket, and other schemes.
• Updated sanitize endpoint test; behavior unchanged.
• Unix socket test covered.
Documentation