feat: allow setting curl connect timeout via env variable #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very welcome fix. |
guites
force-pushed
the
feat-set-curl-connect-timeout-env-var
branch
from
3f828ca to
035fed0
Compare
…t-curl-connect-timeout-env-var
|
Great contribution! This change fixes an important behavior and improves runtime stability. It would be great to have this merged soon — it can save a lot of time for anyone debugging similar issues. 👏 |
…t-curl-connect-timeout-env-var
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows setting the
CURLOPT_CONNECTTIMEOUTvalues in the Docker.php file using environment variables.This improvement helps fix issues such as appwrite/appwrite#8698, https://appwrite.io/threads/1285572082469437581 and other similar problems in appwrite where the user tries to run a function that needs a cold start and receives the following error:
I have found that the reason is that, mainly on the
$executeV5call, the timeout for receiving the first byte is hard coded as a 5.This PR would allow the environment variable to be later exposed to Appwrite and configured to greater values such as 30 seconds for slower machines.
Cheers!