feat: Implemented the RustCrypto traits for signatures and kems (#137) #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds structs Encapsulator and Decacpsulator that implement the RustCrypto traits kem::Encapsulate and kem::Decapsulate, as well as Signer and Verifier that implement signature::Signer and signature::Verifier.
Note that I used version v0.3.0-pre.0 of RustCrypto's KEM trait, and not v0.2.0. The newer traits are much nicer to work with and in particular, don't require to manually define extra types for ciphertext size and shared secret size of each individual KEM. See this issue for a more detailed discussion.
This is my first PR in this project, so please let me know if anything is off.
I read CONTRIBUTING.md and README.md.