IBPSA merge #1466
Merged
IBPSA merge #1466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@kldjonge one "major" change in the PPD12 unit test: Not sure if this looks problematic to you? |
Contributor
|
@jelgerjansen, Doesn't seem problematic to me, RMSE would be virtually unchanged. Also, we've seen it happen before in this specific model where due to changes the controls act a bit earlier/later which causes a peak to appear/dissapear in the error. |
lucasverleyen
approved these changes
Oct 1, 2025
Member
lucasverleyen
left a comment
lucasverleyen
left a comment
There was a problem hiding this comment.
@jelgerjansen looks fine! Only one small comment, but I'll already approve.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Among others to include the Airflow component updates (to speed up simulations).