Skip to content

Commit 7065148

Browse files
committed
wip: lint fixes
Signed-off-by: Kris Coleman <[email protected]>
1 parent dc28205 commit 7065148

File tree

10 files changed

+12
-18
lines changed

10 files changed

+12
-18
lines changed

internal/cmd/compare.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import (
1010
"github.com/open-feature/cli/internal/manifest"
1111
"github.com/pterm/pterm"
1212
"github.com/spf13/cobra"
13-
"gopkg.in/yaml.v3"
13+
yaml "gopkg.in/yaml.v3"
1414
)
1515

1616
func GetCompareCmd() *cobra.Command {

internal/generators/csharp/csharp.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ func (g *CsharpGenerator) Generate(params *generators.Params[Params]) error {
133133
Custom: params.Custom,
134134
}
135135

136-
return g.GenerateFile(funcs, csharpTmpl, newParams, "OpenFeature.g.cs")
136+
return g.CommonGenerator.GenerateFile(funcs, csharpTmpl, newParams, "OpenFeature.g.cs")
137137
}
138138

139139
// NewGenerator creates a generator for C#.

internal/generators/golang/golang.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ func (g *GolangGenerator) Generate(params *generators.Params[Params]) error {
140140
},
141141
}
142142

143-
return g.GenerateFile(funcs, golangTmpl, newParams, params.Custom.GoPackage+".go")
143+
return g.CommonGenerator.GenerateFile(funcs, golangTmpl, newParams, params.Custom.GoPackage+".go")
144144
}
145145

146146
// NewGenerator creates a generator for Go.

internal/generators/java/java.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ func (g *JavaGenerator) Generate(params *generators.Params[Params]) error {
141141
Custom: params.Custom,
142142
}
143143

144-
return g.GenerateFile(funcs, javaTmpl, newParams, "OpenFeature.java")
144+
return g.CommonGenerator.GenerateFile(funcs, javaTmpl, newParams, "OpenFeature.java")
145145
}
146146

147147
// NewGenerator creates a generator for Java.

internal/generators/nestjs/nestjs.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ func (g *NestJsGenerator) Generate(params *generators.Params[Params]) error {
5555
Custom: Params{},
5656
}
5757

58-
return g.GenerateFile(funcs, nestJsTmpl, newParams, "openfeature-decorators.ts")
58+
return g.CommonGenerator.GenerateFile(funcs, nestJsTmpl, newParams, "openfeature-decorators.ts")
5959
}
6060

6161
// NewGenerator creates a generator for NestJS.

internal/generators/nodejs/nodejs.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ func (g *NodejsGenerator) Generate(params *generators.Params[Params]) error {
5555
Custom: Params{},
5656
}
5757

58-
return g.GenerateFile(funcs, nodejsTmpl, newParams, "openfeature.ts")
58+
return g.CommonGenerator.GenerateFile(funcs, nodejsTmpl, newParams, "openfeature.ts")
5959
}
6060

6161
// NewGenerator creates a generator for NodeJS.

internal/generators/python/python.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ func (g *PythonGenerator) Generate(params *generators.Params[Params]) error {
154154
Custom: Params{},
155155
}
156156

157-
return g.GenerateFile(funcs, pythonTmpl, newParams, "openfeature.py")
157+
return g.CommonGenerator.GenerateFile(funcs, pythonTmpl, newParams, "openfeature.py")
158158
}
159159

160160
// NewGenerator creates a generator for Python.

internal/generators/react/react.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ func (g *ReactGenerator) Generate(params *generators.Params[Params]) error {
5555
Custom: Params{},
5656
}
5757

58-
return g.GenerateFile(funcs, reactTmpl, newParams, "openfeature.ts")
58+
return g.CommonGenerator.GenerateFile(funcs, reactTmpl, newParams, "openfeature.ts")
5959
}
6060

6161
// NewGenerator creates a generator for React.

internal/manifest/manage.go

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -140,24 +140,18 @@ func writeManifest(path string, manifest *initManifest) error {
140140
// Write to temp file
141141
if _, err := tmpFile.Write(formattedManifest); err != nil {
142142
tmpFile.Close()
143-
if removeErr := fs.Remove(tmpPath); removeErr != nil {
144-
// Log removal error but prioritize the original error
145-
}
143+
_ = fs.Remove(tmpPath) // Ignore cleanup error, prioritize original error
146144
return fmt.Errorf("failed to write temp file: %w", err)
147145
}
148146

149147
if err := tmpFile.Close(); err != nil {
150-
if removeErr := fs.Remove(tmpPath); removeErr != nil {
151-
// Log removal error but prioritize the original error
152-
}
148+
_ = fs.Remove(tmpPath) // Ignore cleanup error, prioritize original error
153149
return fmt.Errorf("failed to close temp file: %w", err)
154150
}
155151

156152
// Atomically rename temp file to target
157153
if err := fs.Rename(tmpPath, path); err != nil {
158-
if removeErr := fs.Remove(tmpPath); removeErr != nil {
159-
// Log removal error but prioritize the original error
160-
}
154+
_ = fs.Remove(tmpPath) // Ignore cleanup error, prioritize original error
161155
return fmt.Errorf("failed to rename temp file: %w", err)
162156
}
163157

internal/manifest/validate.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import (
55
"sort"
66
"strings"
77

8-
"github.com/open-feature/cli/schema/v0"
8+
schema "github.com/open-feature/cli/schema/v0"
99
"github.com/xeipuuv/gojsonschema"
1010
)
1111

0 commit comments

Comments
 (0)