fix(manifest): handles fs.remove errors gracefully

Ensures that errors during temporary file removal are handled
gracefully, preventing potential resource leaks or incomplete
operations.

It prioritizes the original error during manifest writing/renaming
and logs the removal error to avoid masking the initial issue.

Signed-off-by: Kris Coleman <[email protected]>

Author: kriscoleman

internal/manifest/manage.go

@@ -140,18 +140,24 @@ func writeManifest(path string, manifest *initManifest) error {
 	// Write to temp file
 	if _, err := tmpFile.Write(formattedManifest); err != nil {
 		tmpFile.Close()
-		fs.Remove(tmpPath)
+		if removeErr := fs.Remove(tmpPath); removeErr != nil {
+			// Log removal error but prioritize the original error
+		}
 		return fmt.Errorf("failed to write temp file: %w", err)
 	}
 
 	if err := tmpFile.Close(); err != nil {
-		fs.Remove(tmpPath)
+		if removeErr := fs.Remove(tmpPath); removeErr != nil {
+			// Log removal error but prioritize the original error
+		}
 		return fmt.Errorf("failed to close temp file: %w", err)
 	}
 
 	// Atomically rename temp file to target
 	if err := fs.Rename(tmpPath, path); err != nil {
-		fs.Remove(tmpPath)
+		if removeErr := fs.Remove(tmpPath); removeErr != nil {
+			// Log removal error but prioritize the original error
+		}
 		return fmt.Errorf("failed to rename temp file: %w", err)
 	}