Add smart NVR sample with prototype elements in python. #609
Conversation
tjanczak
requested review from
BaoHuiling,
OskarFiedot,
ZiningLi,
dmichalo,
jmotow,
marcin-wadolkowski,
mholowni,
msmiatac,
nszczygl9,
oonyshch,
pbartosik,
qianlongding,
tbujewsk,
walidbarakat,
yangjianfeng1208 and
yunowo
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
pylint
samples/gstreamer/python/smart_nvr/plugins/python/gvaRecorder.py|67 col 4| C0116: Missing function or method docstring (missing-function-docstring)
samples/gstreamer/python/smart_nvr/plugins/python/gvaRecorder.py|73 col 19| C0123: Use isinstance() rather than type() for a typecheck. (unidiomatic-typecheck)
samples/gstreamer/python/smart_nvr/plugins/python/gvaRecorder.py|67 col 27| W0613: Unused argument 'pad' (unused-argument)
samples/gstreamer/python/smart_nvr/plugins/python/gvaRecorder.py|67 col 38| W0613: Unused argument 'u_data' (unused-argument)
samples/gstreamer/python/smart_nvr/plugins/python/gvaRecorder.py|88 col 4| C0116: Missing function or method docstring (missing-function-docstring)
samples/gstreamer/python/smart_nvr/plugins/python/gvaRecorder.py|89 col 15| W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
samples/gstreamer/python/smart_nvr/plugins/python/gvaRecorder.py|89 col 15| R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
samples/gstreamer/python/smart_nvr/plugins/python/gvaRecorder.py|88 col 39| W0613: Unused argument 'splitmux' (unused-argument)
samples/gstreamer/python/smart_nvr/plugins/python/gvaRecorder.py|88 col 62| W0613: Unused argument 'udata' (unused-argument)
samples/gstreamer/python/smart_nvr/smart_nvr.py|22| C0301: Line too long (102/100) (line-too-long)
samples/gstreamer/python/smart_nvr/smart_nvr.py|44| C0303: Trailing whitespace (trailing-whitespace)
samples/gstreamer/python/smart_nvr/smart_nvr.py|65| C0301: Line too long (112/100) (line-too-long)
samples/gstreamer/python/smart_nvr/smart_nvr.py|68| C0301: Line too long (104/100) (line-too-long)
samples/gstreamer/python/smart_nvr/smart_nvr.py|74| C0301: Line too long (106/100) (line-too-long)
samples/gstreamer/python/smart_nvr/smart_nvr.py|77| C0304: Final newline missing (missing-final-newline)
samples/gstreamer/python/smart_nvr/smart_nvr.py|1| C0114: Missing module docstring (missing-module-docstring)
samples/gstreamer/python/smart_nvr/smart_nvr.py|12| C0413: Import "from gi.repository import GLib, Gst, GstAnalytics, GObject" should be placed at the top of the module (wrong-import-position)
samples/gstreamer/python/smart_nvr/smart_nvr.py|12| E0611: No name 'Gst' in module 'gi.repository' (no-name-in-module)
samples/gstreamer/python/smart_nvr/smart_nvr.py|12| E0611: No name 'GstAnalytics' in module 'gi.repository' (no-name-in-module)
samples/gstreamer/python/smart_nvr/smart_nvr.py|13| E0401: Unable to import 'ultralytics' (import-error)
samples/gstreamer/python/smart_nvr/smart_nvr.py|13| C0413: Import "from ultralytics import YOLO" should be placed at the top of the module (wrong-import-position)
samples/gstreamer/python/smart_nvr/smart_nvr.py|16| C0116: Missing function or method docstring (missing-function-docstring)
samples/gstreamer/python/smart_nvr/smart_nvr.py|35| C0116: Missing function or method docstring (missing-function-docstring)
samples/gstreamer/python/smart_nvr/smart_nvr.py|39 col 14| W1309: Using an f-string that does not have any interpolated variables (f-string-without-interpolation)
samples/gstreamer/python/smart_nvr/smart_nvr.py|12| W0611: Unused GLib imported from gi.repository (unused-import)
samples/gstreamer/python/smart_nvr/smart_nvr.py|12| W0611: Unused GstAnalytics imported from gi.repository (unused-import)
samples/gstreamer/python/smart_nvr/smart_nvr.py|12| W0611: Unused GObject imported from gi.repository (unused-import)
| # | ||
| class Analytics(GstBase.BaseTransform): | ||
| __gstmetadata__ = ('GVA Analytics Python','Transform', \ | ||
| 'Single-camera analytics element to count objects and generate tripwire events', \ |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
C0301: Line too long (104/100) (line-too-long)
| @@ -0,0 +1,38 @@ | |||
| #!/usr/bin/env python | |||
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
C0114: Missing module docstring (missing-module-docstring)
| @@ -0,0 +1,38 @@ | |||
| #!/usr/bin/env python | |||
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
C0103: Module name "gvaAnalytics" doesn't conform to snake_case naming style (invalid-name)
|
Can you also add a README to the sample to describe the sample, similar to the other sample scripts, please? |
Yes, it will be full sample app with README and instructions how to use it - it is a draft PR for now... |
2 participants
Description
Please include a summary of the changes and the related issue. List any dependencies that are required for this change.
Fixes # (issue)
Any Newly Introduced Dependencies
Please describe any newly introduced 3rd party dependencies in this change. List their name, license information and how they are used in the project.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: