Sample application demonstrating ONVIF Camera Discovery and DL Streamer Pipeline Launcher

[jmotow]

Implementation of sample of cameras discovery and DLS pipeline execution based on ONVIF protocol.

[github-actions]

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

pylint

samples/gstreamer/python/onvif_cameras_discovery/dls_onvif_discovery_utils.py|251 col 22| W1309: Using an f-string that does not have any interpolated variables (f-string-without-interpolation)
samples/gstreamer/python/onvif_cameras_discovery/dls_onvif_discovery_utils.py|265 col 12| W0212: Access to a protected member _ptz_name of a client class (protected-access)
samples/gstreamer/python/onvif_cameras_discovery/dls_onvif_discovery_utils.py|266 col 12| W0212: Access to a protected member _ptz_token of a client class (protected-access)
samples/gstreamer/python/onvif_cameras_discovery/dls_onvif_discovery_utils.py|267 col 12| W0212: Access to a protected member _ptz_node_token of a client class (protected-access)
samples/gstreamer/python/onvif_cameras_discovery/dls_onvif_discovery_utils.py|269 col 22| W1309: Using an f-string that does not have any interpolated variables (f-string-without-interpolation)
samples/gstreamer/python/onvif_cameras_discovery/dls_onvif_discovery_utils.py|282 col 15| W0718: Catching too general exception Exception (broad-exception-caught)
samples/gstreamer/python/onvif_cameras_discovery/dls_onvif_discovery_utils.py|174| R0912: Too many branches (36/12) (too-many-branches)
samples/gstreamer/python/onvif_cameras_discovery/dls_onvif_discovery_utils.py|174| R0915: Too many statements (94/50) (too-many-statements)
samples/gstreamer/python/onvif_cameras_discovery/dls_onvif_discovery_utils.py|302 col 18| W1309: Using an f-string that does not have any interpolated variables (f-string-without-interpolation)
samples/gstreamer/python/onvif_cameras_discovery/dls_onvif_discovery_utils.py|310 col 18| W1309: Using an f-string that does not have any interpolated variables (f-string-without-interpolation)
samples/gstreamer/python/onvif_cameras_discovery/dls_onvif_discovery_utils.py|328 col 18| W1309: Using an f-string that does not have any interpolated variables (f-string-without-interpolation)
samples/gstreamer/python/onvif_cameras_discovery/dls_onvif_discovery_utils.py|345 col 18| W1309: Using an f-string that does not have any interpolated variables (f-string-without-interpolation)
samples/gstreamer/python/onvif_cameras_discovery/dls_onvif_discovery_utils.py|351 col 18| W1309: Using an f-string that does not have any interpolated variables (f-string-without-interpolation)
samples/gstreamer/python/onvif_cameras_discovery/dls_onvif_discovery_utils.py|360 col 18| W1309: Using an f-string that does not have any interpolated variables (f-string-without-interpolation)
samples/gstreamer/python/onvif_cameras_discovery/dls_onvif_discovery_utils.py|295| R0912: Too many branches (31/12) (too-many-branches)
samples/gstreamer/python/onvif_cameras_discovery/dls_onvif_discovery_utils.py|295| R0915: Too many statements (57/50) (too-many-statements)
samples/gstreamer/python/onvif_cameras_discovery/dls_onvif_discovery_utils.py|8| C0411: standard import "xml.etree.ElementTree" should be placed before third party import "onvif.ONVIFCamera" (wrong-import-order)
samples/gstreamer/python/onvif_cameras_discovery/dls_onvif_discovery_utils.py|9| C0411: standard import "urllib.parse.urlparse" should be placed before third party import "onvif.ONVIFCamera" (wrong-import-order)
samples/gstreamer/python/onvif_cameras_discovery/dls_onvif_discovery_utils.py|10| C0411: standard import "socket" should be placed before third party import "onvif.ONVIFCamera" (wrong-import-order)
samples/gstreamer/python/onvif_cameras_discovery/dls_onvif_discovery_utils.py|11| C0411: standard import "time" should be placed before third party import "onvif.ONVIFCamera" (wrong-import-order)
samples/gstreamer/python/onvif_cameras_discovery/dls_onvif_discovery_utils.py|12| C0411: standard import "re" should be placed before third party import "onvif.ONVIFCamera" (wrong-import-order)
samples/gstreamer/python/onvif_cameras_discovery/dls_onvif_discovery_utils.py|13| C0411: standard import "json" should be placed before third party import "onvif.ONVIFCamera" (wrong-import-order)
samples/gstreamer/python/onvif_cameras_discovery/dls_onvif_discovery_utils.py|14| C0411: standard import "typing.Optional" should be placed before third party import "onvif.ONVIFCamera" (wrong-import-order)
samples/gstreamer/python/onvif_cameras_discovery/dls_onvif_discovery_utils.py|7| W0611: Unused ONVIFCamera imported from onvif (unused-import)
samples/gstreamer/python/onvif_cameras_discovery/dls_onvif_discovery_utils.py|14| W0611: Unused Dict imported from typing (unused-import)
samples/gstreamer/python/onvif_cameras_discovery/dls_onvif_sample.py|46 col 31| C0303: Trailing whitespace (trailing-whitespace)
samples/gstreamer/python/onvif_cameras_discovery/dls_onvif_sample.py|47 col 52| C0303: Trailing whitespace (trailing-whitespace)
samples/gstreamer/python/onvif_cameras_discovery/dls_onvif_sample.py|52 col 31| C0303: Trailing whitespace (trailing-whitespace)
samples/gstreamer/python/onvif_cameras_discovery/dls_onvif_sample.py|53 col 52| C0303: Trailing whitespace (trailing-whitespace)
samples/gstreamer/python/onvif_cameras_discovery/dls_onvif_sample.py|139| C0305: Trailing newlines (trailing-newlines)
samples/gstreamer/python/onvif_cameras_discovery/dls_onvif_sample.py|1| C0114: Missing module docstring (missing-module-docstring)
samples/gstreamer/python/onvif_cameras_discovery/dls_onvif_sample.py|14| E0401: Unable to import 'onvif' (import-error)
samples/gstreamer/python/onvif_cameras_discovery/dls_onvif_sample.py|16 col 24| W0621: Redefining name 'command' from outer scope (line 103) (redefined-outer-name)
samples/gstreamer/python/onvif_cameras_discovery/dls_onvif_sample.py|32 col 8| W0621: Redefining name 'process' from outer scope (line 118) (redefined-outer-name)
samples/gstreamer/python/onvif_cameras_discovery/dls_onvif_sample.py|25 col 15| W0718: Catching too general exception Exception (broad-exception-caught)
samples/gstreamer/python/onvif_cameras_discovery/dls_onvif_sample.py|59 col 11| W0718: Catching too general exception Exception (broad-exception-caught)
samples/gstreamer/python/onvif_cameras_discovery/dls_onvif_sample.py|32 col 18| R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
samples/gstreamer/python/onvif_cameras_discovery/dls_onvif_sample.py|64 col 24| W0621: Redefining name 'rtsp_url' from outer scope (line 111) (redefined-outer-name)
samples/gstreamer/python/onvif_cameras_discovery/dls_onvif_sample.py|10| C0411: standard import "json" should be placed before third party imports "dls_onvif_data", "dls_onvif_discovery_utils" (wrong-import-order)
samples/gstreamer/python/onvif_cameras_discovery/dls_onvif_sample.py|11| C0411: standard import "typing.Optional" should be placed before third party imports "dls_onvif_data", "dls_onvif_discovery_utils" (wrong-import-order)
samples/gstreamer/python/onvif_cameras_discovery/dls_onvif_sample.py|12| C0411: standard import "subprocess" should be placed before third party imports "dls_onvif_data", "dls_onvif_discovery_utils" (wrong-import-order)
samples/gstreamer/python/onvif_cameras_discovery/dls_onvif_sample.py|13| C0411: standard import "threading" should be placed before third party imports "dls_onvif_data", "dls_onvif_discovery_utils" (wrong-import-order)
samples/gstreamer/python/onvif_cameras_discovery/dls_onvif_sample.py|10| W0611: Unused import json (unused-import)
samples/gstreamer/python/onvif_cameras_discovery/dls_onvif_sample.py|11| W0611: Unused Optional imported from typing (unused-import)
samples/gstreamer/python/onvif_cameras_discovery/dls_onvif_sample.py|11| W0611: Unused Dict imported from typing (unused-import)
samples/gstreamer/python/onvif_cameras_discovery/dls_onvif_sample.py|11| W0611: Unused List imported from typing (unused-import)

[tbujewsk]

Add short intro to '3. Python samples' section in
https://github.com/open-edge-platform/dlstreamer/tree/main/samples/gstreamer#readme

[dmichalo]

Thanks for fixing all findings! :)

[oonyshch]

LGTM, you addressed it all.