show feedback form only if maintainer_email is provided #1636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JVickery-TBS
approved these changes
Dec 9, 2025
Contributor
JVickery-TBS
left a comment
JVickery-TBS
left a comment
There was a problem hiding this comment.
cool, and then I guess this would take major affect once we deal with the Output validator thing. Which is the canada_maintainer_email_default validator in validators.py
should that be handled in a different PR??
Contributor
|
I guess we could comment out the |
Contributor
|
Yeah doubt we are gunna be doing the org email list anytime soon, so better to just remove all that validator code now and we can just make something slimmer in the future if biz decides to do the venture |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.