Skip to content

Remove Resource View Embed Button #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JVickery-TBS merged 2 commits into from
Dec 19, 2025
Merged

Remove Resource View Embed Button #216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8eabec0
removal(templates): resource view embed;
JVickery-TBS Dec 19, 2025
4f3a861
feat(misc): changelog;
JVickery-TBS Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/216.canada.removal
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Removed the Resource View embed button and modal due to `X-Frame-Options: SAMEORIGIN` security requirement preventing embeds.
35 changes: 2 additions & 33 deletions ckan/templates/package/snippets/resource_view.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,7 @@
<i class="fa fa-arrows-alt"></i>
{{ _("Fullscreen") }}
</a>
{# (canada fork only): non-qualified URIs #}
<a class="btn btn-default"
href="#embed-{{ resource_view['id'] }}"
data-module="resource-view-embed"
data-module-id="{{ resource_view['id'] }}"
data-module-url="{{ h.url_for('resource_view', id=package['name'], resource_id=resource['id'], view_id=resource_view['id'], qualified=false) }}">
<i class="fa fa-code"></i>
{{ _("Embed") }}
</a>
{# (canada fork only): remove embed dur to X-Frame-Options:SAMEORIGIN #}
</div>
{% block description %}
<p class="desc">{{ h.render_markdown(resource_view['description']) }}</p>
Expand Down Expand Up @@ -72,29 +64,6 @@
</iframe>
{% endif %}
</div>
<div id="embed-{{ resource_view['id'] }}" class="modal fade resource-view-embed">
<div class="modal-dialog">
<div class="modal-content">

<div class="modal-header">
<h3 class="modal-title">{{ _("Embed resource view") }}</h3>
<button type="button" class="btn-close" data-bs-dismiss="modal" aria-label="{{ _('Close') }}"></button>

</div>
<div class="modal-body">
<p class="embed-content">{{ _("You can copy and paste the embed code into a CMS or blog software that supports raw HTML") }}</p>
<div class="row">
<div class="col-md-6">
{{ form.input("width", label=_("Width"), value=700, classes=["control-full"]) }}
</div>
<div class="col-md-6">
{{ form.input("height", label=_("Height"), value=400, classes=["control-full"]) }}
</div>
</div>
{{ form.textarea("code", label=_("Code"), value="", classes=["pre"], rows=3) }}
</div>
</div>
</div>
</div>
{# (canada fork only): remove embed dur to X-Frame-Options:SAMEORIGIN #}
</div>
{% endblock %}