Skip to content

More i18n for Autocomplete JS Module #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JVickery-TBS merged 2 commits into from
Dec 9, 2025
Merged

More i18n for Autocomplete JS Module #215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e930a1a
feat(i18n): autcomplete more i18n;
JVickery-TBS Dec 9, 2025
5a4b26f
feat(misc): changelog;
JVickery-TBS Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/215.canada.changes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Added French translation for `Searching...` in the Select2 JS autocomplete module.
14 changes: 14 additions & 0 deletions ckan/public/base/javascript/modules/autocomplete.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ this.ckan.module('autocomplete', function (jQuery) {
formatResult: this.formatResult,
formatNoMatches: this.formatNoMatches,
formatInputTooShort: this.formatInputTooShort,
// (canada fork only): more i18n
// TODO: upstream contrib!!
formatSearching: this.formatSearching,
dropdownCssClass: this.options.dropdownClass,
containerCssClass: this.options.containerClass,
tokenSeparators: this.options.tokensep.split(''),
Expand Down Expand Up @@ -236,6 +239,17 @@ this.ckan.module('autocomplete', function (jQuery) {
);
},

/* (canada fork only): more i18n
* TODO: upstream contrib!!
* Formatter used by the select2 plugin that returns a string when
* XHR is being performed.
*
* Returns a string.
*/
formatSearching: function () {
return this._('Searching...');
},

formatTerm: function (term) {
// (canada fork only): initial label
if( this.options.initial_value.length > 0 ){
Expand Down