Skip to content

Implement #ui2#cl_json=>raw_to_string & visceversa #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 30, 2025
Merged

Implement #ui2#cl_json=>raw_to_string & visceversa #924

merged 2 commits into from
Jan 30, 2025

Conversation

HOUNDmx
Copy link
Contributor

@HOUNDmx HOUNDmx commented Jan 30, 2025 •
edited
Loading

Tackles #923

@HOUNDmx
Copy link
Contributor Author

HOUNDmx commented Jan 30, 2025

alright basic stuff up

@HOUNDmx HOUNDmx marked this pull request as ready for review January 30, 2025 16:41
@larshp
Copy link
Member

larshp commented Jan 30, 2025

oh, its just conversion? then call methods cl_abap_codepage=>convert_from and cl_abap_codepage=>convert_to in the implementation

@HOUNDmx
Copy link
Contributor Author

HOUNDmx commented Jan 30, 2025

Hmmm, It seems like it, you can also provide an encoding tho, maybe codepage does the same? I don't know, but I don't need it, so, remove it?

@larshp
Copy link
Member

larshp commented Jan 30, 2025

yea, if you dont need the encoding parameter, skip it for now, can be added later

larshp
larshp approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@larshp larshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it, choo choo 🚂

@larshp larshp merged commit f1a499f into open-abap:main Jan 30, 2025
6 checks passed
@HOUNDmx HOUNDmx mentioned this pull request Jan 30, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larshp larshp larshp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HOUNDmx @larshp