DBQnA: Unified POST data format, and fix judgment logic. #2153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
There was a problem hiding this comment.
Pull Request Overview
This PR unifies the POST data format for database connection requests and improves the success status judgment logic in the DBConnect component. The changes standardize how connection data is sent to the backend and make the success detection more robust.
- Modified database connection request format to wrap connection parameters in a unified structure
- Updated success status detection to be case-insensitive and use substring matching
- Changed default host from a specific IP to localhost
Comments suppressed due to low confidence (1)
DBQnA/ui/react/src/components/DbConnect/DBConnect.tsx:45
- [nitpick] The variable name 'unifiedConnData' uses inconsistent naming convention. Consider using camelCase 'unifiedConnectionData' or snake_case consistently throughout the codebase.
let unifiedConnData = {"conn_str":formData};
|
Local test passed. The test will not be triggered because of CI hardware limitations. |
letonghan
approved these changes
Aug 1, 2025
Signed-off-by: ZePan110 <[email protected]>
chensuyue
approved these changes
Aug 11, 2025
alexsin368
pushed a commit
to alexsin368/GenAIExamples
that referenced
this pull request
Aug 13, 2025
…t#2153) Signed-off-by: ZePan110 <[email protected]> Signed-off-by: alexsin368 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Further fixe judgment logic based on #2076
Issues
#2146
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.