Skip to content

re-open rocm test in CI/CD #2120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

re-open rocm test in CI/CD #2120

wants to merge 1 commit into from

Conversation

chensuyue
Copy link
Collaborator

@chensuyue chensuyue commented Jul 7, 2025

Description

Re-open rocm test in CI/CD, since ROCm test machine comes back.

Issues

Revert PR https://github.com/opea-project/GenAIExamples/pull/2017/files

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

Signed-off-by: chensuyue <[email protected]>
@Copilot Copilot AI review requested due to automatic review settings July 7, 2025 03:43
@chensuyue chensuyue requested a review from ZePan110 as a code owner July 7, 2025 03:43
Copy link

github-actions bot commented Jul 7, 2025

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Re-enable ROCm tests in the CI/CD pipeline now that the ROCm test machine is back online.

  • Include “rocm” in the list of testing nodes.
  • Remove the temporary skip logic for ROCm in the test matrix script.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/weekly-example-test.yml Added “rocm” to the NODES environment variable.
.github/workflows/scripts/get_test_matrix.sh Removed the conditional block that skipped ROCm.

@chensuyue chensuyue added the WIP label Jul 8, 2025
@CICD-at-OPEA
Copy link
Collaborator

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@CICD-at-OPEA
Copy link
Collaborator

This PR was closed because it has been stalled for 7 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants