-
Notifications
You must be signed in to change notification settings - Fork 307
Fix workexec agent docker build issues and enable LLM Remote Endpoint #2103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
33f542e
to
84c1f75
Compare
be3e1f1
to
efa00c5
Compare
@@ -4,7 +4,7 @@ | |||
services: | |||
agent: | |||
build: | |||
context: GenAIComps | |||
context: ${WORKDIR:-./}/GenAIComps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change causes the duplicated images error here. Is it necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the original flow, and I just change the path where GenAIcomps is located. it seems that multiple examples like agentqna, audioqna and workflowagent build the agent image. don't quite understand why multiple builds cause issues. any suggestion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the CI check to make sure unified docker image path.
@chensuyue Could you help to check this, is it possible to skip this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This issue means all the image named opea/agent
should build from the same dockerfile. And the scripts think ${WORKDIR:-./}/GenAIComps/comps/agent/src/Dockerfile
in this build yaml is different with GenAIComps/comps/agent/src/Dockerfile
used by other build yaml.
Is this change force required? If not, you can just recover the change here to avoid the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
recovered it and changed README instructions instead. after recovery, we will have GenAIComp github repo under GenAIExamples. it looks confusing, but it should work
efa00c5
to
8f9a4e4
Compare
Signed-off-by: Tsai, Louie <[email protected]>
Signed-off-by: Tsai, Louie <[email protected]>
Signed-off-by: Tsai, Louie <[email protected]>
6502cd1
to
41f441e
Compare
Signed-off-by: Tsai, Louie <[email protected]>
7b02487
to
f78a753
Compare
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Description
Fix Some issues for workexec agent docker build and enable Intel Enterprise Inference as LLM remote endpoint
https://github.com/opea-project/Enterprise-Inference
Issues
Addressing this feature request for 1.4 rleease
#1973
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
NA
Tests
manual testing