Skip to content

Audioqna: fix input for TTS service, enable remote endpoints #2101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

alexsin368
Copy link
Collaborator

@alexsin368 alexsin368 commented Jun 27, 2025

Description

Fixes the input for the TTS service when aligning inputs.
Add support for OpenAI API remote endpoints.

Issues

#1973

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

None.

Tests

Tested megaservice functionality with remote endpoints via curl commands.
Plan to add/modify test script.

@Copilot Copilot AI review requested due to automatic review settings June 27, 2025 00:10
Copy link

github-actions bot commented Jun 27, 2025

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes the TTS input processing and adds support for handling remote endpoints for the LLM service. Key changes include:

  • Adding a new docker compose file (compose_remote.yaml) for remote endpoint configuration.
  • Updating the README with instructions for setting new environment variables.
  • Modifying the AudioQnA service to read and propagate the OPENAI_API_KEY and adjust input/output alignment for TTS and LLM services.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
AudioQnA/docker_compose/intel/cpu/xeon/compose_remote.yaml New compose file to configure remote endpoints and service ports.
AudioQnA/docker_compose/intel/cpu/xeon/README.md Updated documentation with instructions for environment variable setup for remote LLM endpoints.
AudioQnA/audioqna.py Updated input alignment for TTS, added support for API key, and introduced new output alignment and generator logic.
Comments suppressed due to low confidence (2)

AudioQnA/docker_compose/intel/cpu/xeon/compose_remote.yaml:42

  • The assignment of LLM_SERVER_HOST_IP from the REMOTE_ENDPOINT variable may be confusing. Consider aligning the variable names or adding a comment to clarify the intended use.
      - LLM_SERVER_HOST_IP=${REMOTE_ENDPOINT}

AudioQnA/audioqna.py:103

  • [nitpick] Consider adding documentation or inline comments to explain the use and expected format of the OPENAI_API_KEY parameter in add_remote_service.
            api_key=OPENAI_API_KEY,

@alexsin368 alexsin368 force-pushed the audioqna-remote-endpoint branch from f897282 to c21f034 Compare June 27, 2025 00:12
@alexsin368 alexsin368 requested a review from louie-tsai June 27, 2025 00:54
@alexsin368
Copy link
Collaborator Author

tested and verified functionality of megaservice with remote endpoint using curl commands

@alexsin368 alexsin368 modified the milestone: v1.4 Jul 3, 2025
@CICD-at-OPEA
Copy link
Collaborator

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@alexsin368 alexsin368 requested a review from amberjain1 August 5, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants