Skip to content

Conversation

chyundunovDatamonsters
Copy link
Contributor

Description

Adding files to deploy an application in the K8S environment using Helm

Issues

Type of change

List the type of change like below. Please delete options that are not relevant.

  • [*] New feature (non-breaking change which adds new functionality)

Dependencies

Tests

Copy link

github-actions bot commented Apr 5, 2025

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

@chensuyue chensuyue added this to the v1.4 milestone Apr 10, 2025
@chensuyue chensuyue mentioned this pull request Apr 10, 2025
4 tasks
@yinghu5 yinghu5 requested a review from yongfengdu April 24, 2025 01:29
Signed-off-by: Chingis Yundunov <[email protected]>
Copy link
Collaborator

@mkbhanda mkbhanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor edits


#### If ROCm vLLM used
```bash
nano ~/chatqna-k8s-install/GenAIExamples/ChatQnA/kubernetes/helm/rocm-values.yaml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could assume you are already in the correct directory, namely
~/chatqna-k8s-install/GenAIExamples/ChatQnA/kubernetes/helm


#### If deploy FaqGen based application on AMD ROCm device with vLLM
```bash
nano ~/chatqna-k8s-install/GenAIExamples/ChatQnA/kubernetes/helm/faqgen-rocm-values.yaml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto, could assume you are in the correct directory

#### If ROCm TGI used

```bash
nano ~/chatqna-k8s-install/GenAIExamples/ChatQnA/kubernetes/helm/rocm-tgi-values.yaml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto on directory


### Installing the Helm Chart

#### If ROCm vLLM used
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this heading not bold faced while others below are?

@yinghu5 yinghu5 requested a review from lianhao May 7, 2025 06:21
@yinghu5
Copy link
Collaborator

yinghu5 commented May 7, 2025

Hi @yongfengdu @lianhao
Could you please help to review the PR? thank you!

pre-commit-ci bot and others added 12 commits May 16, 2025 20:18
for more information, see https://pre-commit.ci

Signed-off-by: Chingis Yundunov <[email protected]>
Co-authored-by: Malini Bhandaru <[email protected]>
Signed-off-by: Chingis Yundunov <[email protected]>
…-GenAIExamples into feature/ChatQnA_k8s

# Conflicts:
#	DocSum/docker_compose/amd/gpu/rocm/README.md
@yinghu5
Copy link
Collaborator

yinghu5 commented May 23, 2025

Hi @chyundunovDatamonsters, seems two CI failed. Could you please help to check? thank you!

@yongfengdu
Copy link
Collaborator

@chyundunovDatamonsters Please fix the minor issues of README and rebase with latest changes before we can merge this.

@CICD-at-OPEA
Copy link
Collaborator

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@chensuyue chensuyue removed the Stale label Aug 11, 2025
@chensuyue chensuyue modified the milestones: v1.4, v1.5 Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.