Deploy check in to prod #246
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terraform Run Output 🤖Format and Style 🖌
|
| Pusher | @LDiazN |
| Action | pull_request |
| Environment | dev |
| Workflow | .github/workflows/check_terraform.yml |
| Last updated | Mon, 26 May 2025 11:08:33 GMT |
Ansible Run Output 🤖Ansible Playbook Recap 🔍Ansible playbook output 📖
|
| Pusher | @LDiazN |
| Action | pull_request |
| Working Directory | |
| Workflow | .github/workflows/check_ansible.yml |
| Last updated | Mon, 26 May 2025 11:09:04 GMT |
hellais
reviewed
May 26, 2025
| @@ -13,7 +13,7 @@ | |||
| tls_cert_dir: /var/lib/dehydrated/certs | |||
| - role: clickhouse_proxy | |||
| vars: | |||
| clickhouse_url: "clickhouse3.prod.ooni.io" | |||
| clickhouse_url: "{{'clickhouse1.prod.ooni.io' if inventory_hostname == 'clickhouseproxy.prod.ooni.io' else 'clickhouse3.prod.ooni.io'}}" | |||
There was a problem hiding this comment.
I wonder if should be using dev and prod groups to specify these urls differently
hellais
reviewed
May 26, 2025
| @@ -15,6 +15,8 @@ nftables_clickhouse_allow: | |||
| ip: 5.9.112.244 | |||
| - fqdn: clickhouseproxy.dev.ooni.io | |||
| ip: "{{ lookup('dig', 'clickhouseproxy.dev.ooni.io/A') }}" | |||
| - fqdn: clickhouseproxy.prod.ooni.io | |||
| ip: "{{ lookup('dig', 'clickhouseproxy.prod.ooni.io/A') }}" | |||
There was a problem hiding this comment.
Same as above, even moreso important here, since ideally we would not allow access to the production clickhouse from the dev environment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides the necessary set up to deploy check-in to prod, including:
clickhouseproxy.prod.ooni.ioto data1deploy-clickhouse-proxy.ymlrole depending on the host (prod or dev)We still need to point the load balancer to the right service but I would rather do that when we already tested these things
closes #227