-
Notifications
You must be signed in to change notification settings - Fork 30
Oonirun v2 1 #962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Oonirun v2 1 #962
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project check has failed because the head coverage (82.76%) is below the target coverage (95.00%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## master #962 +/- ##
==========================================
- Coverage 91.81% 82.76% -9.05%
==========================================
Files 61 19 -42
Lines 5179 1938 -3241
Branches 339 208 -131
==========================================
- Hits 4755 1604 -3151
+ Misses 365 285 -80
+ Partials 59 49 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This is a good start, I left a few comments for things to improve or change. Regarding handling of the For the moment we only support the |
ooniapi/common/src/common/alembic/versions/b860eb79750f_add_targets_name_and_inputs_extra_.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments for things to go over before merging.
Also, I noticed in several places there is some odd formatting (eg. there being an extra space around :
, like "foo" : "bar"
). Could you run black
on all the files you edited to make the formatting consistent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is PR is good to go.
The steps to get this into production are:
- Deploy this branch into the dev environment by updating the terraform configs
- Run migration on the dev database
- Test that the dev environment with OONI Run v2.1 works on the OONI Probe mobile apps
- Test that the dev environment with OONI Run v2.1 works with
miniooni
- Merge this PR which will lead to a production deployment
- Run migration on the prod database
Add DB model migrations, new view models and some tests. Related to #955