Skip to content

Remove /api from links to coincide with latest server version.#42

Open
Doru991 wants to merge 1 commit into
mainfrom
no-api-links
Open

Remove /api from links to coincide with latest server version.#42
Doru991 wants to merge 1 commit into
mainfrom
no-api-links

Conversation

@Doru991
Copy link
Copy Markdown
Contributor

@Doru991 Doru991 commented Mar 6, 2026

Should be merged at the same time as onlinedi-vision/od-official-server#57 takes effect. Removes /api from server API endpoints. Also I may have accidentally pushed to main at first because my hands were on autopilot, sorry about that.

This reverts commit 4c088a3.
@kickhead13
Copy link
Copy Markdown
Member

Hi can this be tested somehow?

Copy link
Copy Markdown
Member

@kickhead13 kickhead13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me.

Also to reproduce locally you can run this script:

#!/usr/bin/env bash
# shellcheck enable=all

set -xe

WORKSPACE=$(pwd)

git clone https://github.com/onlinedi-vision/od-official-server
git clone https://github.com/onlinedi-vision/od-client

cd "${WORKSPACE}"/od-official-server
sed -i 's/- TOKEN_TTL=2/#- TOKEN_TTL=2/' test-env-compose/od-official-server.yaml
./launch-test-env.sh -ue

cd "${WORKSPACE}"/od-client
git fetch --all --prune --progress
git checkout no-api-links
find src src-tauri -type f -prune -exec sed -i -e 's/api\.onlinedi\.vision/localhost:1313/' -e 's/https/http/' {} \;
npm i
npm run tauri dev

This should set up the environment for the client to run with the new endpoints (locally). At the very end (this will take a while if you dont have the scylla docker image and the od-official-server docker image) it will open od-client connected to a local instance of the api server. Now you can play around and see that it (probably) works.

Keep in mind this script wont create a local websockets server so you won't be able to send messages instantly (you will have to reload after each message sent).

Copy link
Copy Markdown
Member

@AlexDuna AlexDuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Copy Markdown
Contributor

@ValentinNimigean ValentinNimigean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work!

Copy link
Copy Markdown
Member

@kickhead13 kickhead13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't be merged yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants