Remove /api from links to coincide with latest server version.#42
Open
Doru991 wants to merge 1 commit into
Open
Remove /api from links to coincide with latest server version.#42Doru991 wants to merge 1 commit into
Doru991 wants to merge 1 commit into
Conversation
This reverts commit 4c088a3.
Member
|
Hi can this be tested somehow? |
kickhead13
approved these changes
Mar 6, 2026
Member
There was a problem hiding this comment.
All looks good to me.
Also to reproduce locally you can run this script:
#!/usr/bin/env bash
# shellcheck enable=all
set -xe
WORKSPACE=$(pwd)
git clone https://github.com/onlinedi-vision/od-official-server
git clone https://github.com/onlinedi-vision/od-client
cd "${WORKSPACE}"/od-official-server
sed -i 's/- TOKEN_TTL=2/#- TOKEN_TTL=2/' test-env-compose/od-official-server.yaml
./launch-test-env.sh -ue
cd "${WORKSPACE}"/od-client
git fetch --all --prune --progress
git checkout no-api-links
find src src-tauri -type f -prune -exec sed -i -e 's/api\.onlinedi\.vision/localhost:1313/' -e 's/https/http/' {} \;
npm i
npm run tauri devThis should set up the environment for the client to run with the new endpoints (locally). At the very end (this will take a while if you dont have the scylla docker image and the od-official-server docker image) it will open od-client connected to a local instance of the api server. Now you can play around and see that it (probably) works.
Keep in mind this script wont create a local websockets server so you won't be able to send messages instantly (you will have to reload after each message sent).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should be merged at the same time as onlinedi-vision/od-official-server#57 takes effect. Removes
/apifrom server API endpoints. Also I may have accidentally pushed to main at first because my hands were on autopilot, sorry about that.