Fix/atcoder memory notation change #173
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koba-e964
reviewed
Jun 15, 2025
| if tds[3].text.endswith(' KiB'): | ||
| memory_limit_byte = int(float(utils.remove_suffix(tds[3].text, ' KiB')) * 1024) | ||
| elif tds[3].text.endswith(' MiB'): | ||
| memory_limit_byte = int(float(utils.remove_suffix(tds[3].text, ' MiB')) * 1024 * 1024) # TODO: confirm this is MB truly, not MiB |
There was a problem hiding this comment.
Suggested change
| memory_limit_byte = int(float(utils.remove_suffix(tds[3].text, ' MiB')) * 1024 * 1024) # TODO: confirm this is MB truly, not MiB | |
| memory_limit_byte = int(float(utils.remove_suffix(tds[3].text, ' MiB')) * 1024 * 1024) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
#172 について、メモリ表記と、計算値を変更しました。
KB→KiB (byte * 1000 → byte * 1024)
MB→MiB(byte * 1000 * 1000 → byte * 1024 * 1024)
あったらごめんなさいなのですが、このプロジェクト内ではテスト時の
[INFO]max memory: ○○MiBを出力する箇所が見つけられなかったのでこの範囲の変更のみ行っています。
why
お手すきの際に確認していただけると幸いです。