Skip to content

Add fee method on transaction results#738

Open
devbugging wants to merge 4 commits intomasterfrom
gregor/result-fees
Open

Add fee method on transaction results#738
devbugging wants to merge 4 commits intomasterfrom
gregor/result-fees

Conversation

@devbugging
Copy link
Copy Markdown
Collaborator

Add a Fee() method on the transaction result, which will return the Flow fee used in transaction execution.

Copy link
Copy Markdown
Contributor

@janezpodhostnik janezpodhostnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Convenient!

Comment thread transaction.go
Comment on lines +643 to +644
feeEvent = e.Value
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
feeEvent = e.Value
}
feeEvent = e.Value
break
}

Comment thread transaction.go
feeEvent = e.Value
}
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fees could be disabled

Suggested change
if feeEvent == nil {
return 0, nil
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants