Conversation
|
This is referring to this pull request on the Crypto-Dappy Github repositroy |
Contributor
So this is not really a CLI feature for state management? |
Contributor
Author
|
@sideninja it is not about CLI feature. It is about decentralized trading based on NFTStorefront contract. The first milestone is about UI. Correct me if I missed anything? |
Contributor
Author
|
By the way I am done with NFTStorefront unit testing. Ready to complete Milestone 2 |
|
Hey @NguyenIvan, just reviewed your solution of milestone number 1, and it fulfils all requirements and can be considered as passed! |
Contributor
Author
|
Thank you very much @bebner. I am heading toward to the next milestone submission. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Title
Please format your PR title as follows:
[Issue Name] - Milestone [Milestone #]Description
This PR is for issue (insert issue number here).
Submission Links & Documents
Requirements Check
Other Details