Skip to content

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Sep 22, 2025

Description

Mostly useful for debugging.

TODO:

  • Tests. IDK how to manually create a map data slab, it seems like the construction is not exported
  • Error wrapping. The PopIterate functions sometimes wrap, sometimes have comments stating wrapping is not necessary. It is not quite clear to me

  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

Copy link
Member Author

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests looks good, thank you for adding them Faye!

@turbolent turbolent merged commit 665b2c8 into main Sep 26, 2025
6 checks passed
@turbolent turbolent deleted the bastian/map-elements-iteration branch September 26, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants