Round down availableBalance to prevent health violation on max withdrawal#317
Open
jordanschalm wants to merge 5 commits intomainfrom
Open
Round down availableBalance to prevent health violation on max withdrawal#317jordanschalm wants to merge 5 commits intomainfrom
jordanschalm wants to merge 5 commits intomainfrom
Conversation
…awal availableBalance was using toUFix64Round (round-half-up) to convert the UFix128 result of maxWithdraw to UFix64. This could return a value slightly above the true maximum, causing withdrawals of the full reported amount to fail with "Insufficient funds" due to breaching minHealth. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jribbink
approved these changes
Apr 9, 2026
Gornutz
approved these changes
Apr 10, 2026
zhangchiqing
approved these changes
Apr 10, 2026
jribbink
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
availableBalancewas using toUFix64Round (round-half-up) to convert the UFix128 result of maxWithdraw to UFix64. This could return a value slightly above the true maximum, causing withdrawals of the full reported amount to fail with "Insufficient funds" due to breachingminHealth.