ADR: Revise interest curve utilization rate definition#303
Merged
jordanschalm merged 5 commits intomainfrom Apr 10, 2026
Merged
ADR: Revise interest curve utilization rate definition#303jordanschalm merged 5 commits intomainfrom
jordanschalm merged 5 commits intomainfrom
Conversation
zhangchiqing
reviewed
Apr 3, 2026
Comment on lines
+24
to
+25
| - User B deposits 105 units of X -> totalDebit(X) = 0 | ||
| - User B still owes 5 units of X, but totalDebit(X) = 0 |
Member
There was a problem hiding this comment.
Why B depositing 105 units would make totalDebit(X) to 0? Could you add more details in the comments.
Member
Author
There was a problem hiding this comment.
Because they are unsigned and clamp to zero. From the paragraph above:
They are stored as absolute (not interest-adjusted) unsigned values, which can cause updates to the values to clamp to zero
Also added a ceil function in the equation to represent the "unsigned-ness"
jordanschalm
commented
Apr 6, 2026
Co-authored-by: Leo Zhang <zhangchiqing@gmail.com> Co-authored-by: Jordan Schalm <jordan.schalm@gmail.com>
holyfuchs
approved these changes
Apr 9, 2026
Gornutz
approved these changes
Apr 9, 2026
zhangchiqing
reviewed
Apr 9, 2026
zhangchiqing
reviewed
Apr 9, 2026
zhangchiqing
approved these changes
Apr 10, 2026
Co-authored-by: Leo Zhang <zhangchiqing@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.