Add test for FetchContent of UMF on Linux and Windows #1384

ldorau · 2025-06-23T11:23:25Z

Description

Test FetchContent of UMF on Linux and Windows -
on Windows with the 'Ninja' and 'NMake Makefiles' generators.

Add the fetch_content example based on the basic example.

Nightly CI build: https://github.com/ldorau/unified-memory-framework/actions/runs/16030235338

Checklist

Code compiles without errors locally
All tests pass locally
CI workflows execute properly

ldorau · 2025-06-23T12:15:07Z

CI builds passed: https://github.com/ldorau/unified-memory-framework/actions/runs/15822815241

ldorau · 2025-06-24T11:03:59Z

The FetchContent CI builds passed: https://github.com/oneapi-src/unified-memory-framework/actions/runs/15823833356/job/44672674939

ldorau · 2025-06-24T11:51:48Z

CI builds passed: https://github.com/oneapi-src/unified-memory-framework/actions/runs/15848792814/job/44678255144

ldorau · 2025-06-27T09:09:29Z

Rebased

ldorau · 2025-06-30T07:09:25Z

Rebased

.github/workflows/reusable_fetch_content.yml

examples/basic/find_umf.cmake

examples/basic/include.cmake

examples/basic/CMakeLists.txt

examples/basic/include.cmake

examples/fetch_content/find_umf.cmake

.github/workflows/pr_push.yml

lukaszstolarczuk · 2025-07-01T09:48:51Z

.github/workflows/reusable_fetch_content.yml

+      run: ./umf_example_fetch_content
+
+  # Build and test the fetch_content example with different CMake generators on Windows
+  Windows-FetchContent:


windows job could be definitely merged into existing nmake/ninja workflows in nigthly; not sure about linux job

examples/fetch_content/fetch_umf.cmake

lukaszstolarczuk · 2025-07-01T09:56:20Z

examples/fetch_content/fetch_umf.cmake

@@ -0,0 +1,64 @@
+# Copyright (C) 2025 Intel Corporation


a general note, not neccessarily needed to be done in this PR - so now, as we test it, perhaps we should add a README section about integration (e.g. like in UR repo: https://github.com/oneapi-src/unified-runtime?tab=readme-ov-file#integration)

We can consider that. The question is if it should be the recommended way to integrate UMF.

hmm yeah, probably we shouldn't say that it's recommended

ldorau · 2025-07-02T13:44:37Z

Nightly CI build: https://github.com/ldorau/unified-memory-framework/actions/runs/16030235338

Test FetchContent of UMF on Linux and Windows in Nightly CI job - on Windows with the 'Ninja' and 'NMake Makefiles' generators. Add the fetch_content example based on the basic example. Signed-off-by: Lukasz Dorau <[email protected]>

lukaszstolarczuk

in general LGTM

lukaszstolarczuk · 2025-07-03T11:57:53Z

.github/workflows/nightly.yml

+    - name: Run the fetch_content example
+      shell: cmd
+      working-directory: ${{github.workspace}}/examples/fetch_content/build
+      run: dir .\umf_example_fetch_content.exe


lukaszstolarczuk · 2025-07-03T11:58:34Z

.github/workflows/nightly.yml

+
+    - name: Build the fetch_content example
+      working-directory: ${{github.workspace}}/examples/fetch_content
+      shell: cmd


default powershell should be ok (just %NUMBER_OF_PROCESSORS% -> $env:NUMBER_OF_PROCESSORS)

lukaszstolarczuk · 2025-07-03T11:58:49Z

.github/workflows/nightly.yml

+      run: cmake --build ${{github.workspace}}/examples/fetch_content/build --config ${{matrix.build_type}} -j %NUMBER_OF_PROCESSORS%
+
+    - name: Run the fetch_content example
+      shell: cmd


default powershell should be ok

lukaszstolarczuk · 2025-07-03T11:59:03Z

.github/workflows/nightly.yml

@@ -201,6 +238,32 @@ jobs:
        ${{ matrix.umfd_lib == 'ON' && '--umfd-lib' || ''}}
        ${{ matrix.static_hwloc == 'ON' && '--hwloc' || '' }}

+    - name: Set VCPKG_PATH with hwloc for the fetch_content example


we already have a step like this, I guess we could just do the same as in that step: add if: matrix.static_hwloc == 'OFF' to the fetch_content example's configure/build/execution steps

lukaszstolarczuk · 2025-07-03T12:00:51Z

examples/fetch_content/CMakeLists.txt

+# Copyright (C) 2025 Intel Corporation
+# Under the Apache License v2.0 with LLVM Exceptions. See LICENSE.TXT.
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+


you could add a short description why do we have this example

examples/fetch_content/fetch_umf.cmake

lukaszstolarczuk · 2025-07-03T12:09:41Z

examples/fetch_content/fetch_umf.cmake

@@ -0,0 +1,64 @@
+# Copyright (C) 2025 Intel Corporation


hmm yeah, probably we shouldn't say that it's recommended

lukaszstolarczuk · 2025-07-03T13:40:46Z

.github/workflows/nightly.yml

@@ -107,6 +107,43 @@ jobs:
    - name: Run tests under valgrind
      run: ${{github.workspace}}/test/test_valgrind.sh ${{github.workspace}} ${{github.workspace}}/build ${{matrix.tool}}

+  Linux-FetchContent:


I can you can drop Linux workflow, if you add this example to standalones execution

in test/CMakeLists.txt
pls add new example in line
set(EXAMPLES ${EXAMPLES} basic custom_file_provider)

// tested on my fork: https://github.com/lukaszstolarczuk/unified-memory-framework/actions/runs/16051712582/job/45295762065#step:11:4294

lukaszstolarczuk · 2025-07-03T13:41:21Z

examples/fetch_content/CMakeLists.txt

+target_include_directories(${EXAMPLE_NAME} PRIVATE ${LIBUMF_INCLUDE_DIRS})
+target_link_directories(${EXAMPLE_NAME} PRIVATE ${LIBHWLOC_LIBRARY_DIRS})
+target_link_libraries(${EXAMPLE_NAME} PRIVATE ${LIBUMF_LIBRARIES} hwloc)
+


could you please add printing of PATHs found in this example and used above..?

// e.g. like here: https://github.com/lukaszstolarczuk/unified-memory-framework/actions/runs/16051712582/job/45295762065#step:11:4353

ldorau requested a review from a team as a code owner June 23, 2025 11:23

ldorau force-pushed the Test_FetchContent_of_UMF_on_Linux_and_Windows branch 4 times, most recently from afd45b5 to cd0640d Compare June 23, 2025 12:10

ldorau force-pushed the Test_FetchContent_of_UMF_on_Linux_and_Windows branch from cd0640d to 09fb801 Compare June 24, 2025 11:08

ldorau force-pushed the Test_FetchContent_of_UMF_on_Linux_and_Windows branch from 09fb801 to 8bb3ebc Compare June 27, 2025 09:09

ldorau force-pushed the Test_FetchContent_of_UMF_on_Linux_and_Windows branch from 8bb3ebc to 9906125 Compare June 30, 2025 07:09

ldorau changed the title ~~Test FetchContent of UMF on Linux and Windows~~ Add tests for FetchContent of UMF on Linux and Windows Jun 30, 2025

ldorau force-pushed the Test_FetchContent_of_UMF_on_Linux_and_Windows branch from 9906125 to 4e4194a Compare June 30, 2025 07:51

bratpiorka requested changes Jun 30, 2025

View reviewed changes

ldorau force-pushed the Test_FetchContent_of_UMF_on_Linux_and_Windows branch from 4e4194a to 64a6257 Compare June 30, 2025 10:16

ldorau requested a review from bratpiorka June 30, 2025 10:18

ldorau changed the title ~~Add tests for FetchContent of UMF on Linux and Windows~~ Add test for FetchContent of UMF on Linux and Windows Jun 30, 2025

lukaszstolarczuk reviewed Jul 1, 2025

View reviewed changes

ldorau force-pushed the Test_FetchContent_of_UMF_on_Linux_and_Windows branch from 64a6257 to b28de77 Compare July 2, 2025 13:42

ldorau force-pushed the Test_FetchContent_of_UMF_on_Linux_and_Windows branch from b28de77 to e2286df Compare July 2, 2025 16:07

ldorau requested a review from lukaszstolarczuk July 2, 2025 16:14

bratpiorka approved these changes Jul 3, 2025

View reviewed changes

lukaszstolarczuk reviewed Jul 3, 2025

View reviewed changes

Add test for FetchContent of UMF on Linux and Windows #1384

Are you sure you want to change the base?

Add test for FetchContent of UMF on Linux and Windows #1384

Uh oh!

Conversation

ldorau commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

ldorau commented Jun 23, 2025

Uh oh!

ldorau commented Jun 24, 2025

Uh oh!

ldorau commented Jun 24, 2025

Uh oh!

ldorau commented Jun 27, 2025

Uh oh!

ldorau commented Jun 30, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ldorau commented Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lukaszstolarczuk left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ldorau commented Jun 23, 2025 •

edited

Loading

ldorau commented Jul 2, 2025 •

edited

Loading