Added validation and new xmlcanonicalizer #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xmlcanonicalizer which works (I was getting weird issues with the other one)
Contributor
Author
|
Ah, I've just noticed the lowercase version is 1.9.2+. Feel free to just close this if you are on 1.8.* |
ghost
assigned
Contributor
Author
|
Hi, I've closed this pull request as I've sent another with the same code and also test coverage (see here: #2) Thanks. |
rajiv
pushed a commit
that referenced
this pull request
Dec 4, 2013
Rack API needs finalise to return correct structure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It didn't seem as though any validation on the signature was actually happening in this code, so I added that line.
Also I'm using a newer version of xmlcanonicalizer (with lowercase not uppercase), which is much more recently maintained and works for me on Ruby 1.9 (the one with uppercases didn't work)