Remove trailing slashes - #18
Open
dominikl wants to merge 1 commit into
Open
Conversation
|
I think this is something we should do, but we should continue to discourage through documentation and tooling the ability to have trailing "/" characters in S3 URIs in the lsids. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently a trailing slash in the URL in ExternalInfo object (e.g.
s3://livingobjects.ebi.ac.uk/idr/test/dom/image.ome.zarr/0/?anonymous=true) will cause(whereas
s3://livingobjects.ebi.ac.uk/idr/test/dom/image.ome.zarr/0?anonymous=trueworks)This PR simply removes trailing slashes.
Is this something worth to consider? Or shall I close the PR and simply file that under "user error" (and maybe add a note about trailing slashes in Readme.md)? @kkoz